From: David Miller <davem@davemloft.net>
To: mcroce@redhat.com
Cc: netdev@vger.kernel.org, sgoutham@cavium.com, rric@kernel.org,
linux-arm-kernel@lists.infradead.org,
ilias.apalodimas@linaro.org, brouer@redhat.com
Subject: Re: [PATCH net v2 0/2] Fix thunderx MTU with XDP
Date: Wed, 10 Apr 2019 19:35:45 -0700 (PDT) [thread overview]
Message-ID: <20190410.193545.867822076372319682.davem@davemloft.net> (raw)
In-Reply-To: <20190410.193516.1892424617872069320.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Wed, 10 Apr 2019 19:35:16 -0700 (PDT)
> From: Matteo Croce <mcroce@redhat.com>
> Date: Mon, 8 Apr 2019 23:06:45 +0200
>
>> The thunderx driver can't use XDP with all MTU values.
>> This patches sets the right MTU values, and add a check to avoid setting
>> a wrong value which will not function.
>
> Series applied and queued up for -stable.
Actually, reverted, -ENOCOMPILE:
drivers/net/ethernet/cavium/thunder/nicvf_main.c: In function ‘nicvf_change_mtu’:
drivers/net/ethernet/cavium/thunder/nicvf_main.c:1596:15: error: ‘dev’ undeclared (first use in this function); did you mean ‘cdev’?
netdev_warn(dev, "Jumbo frames not yet supported with XDP, current MTU %d.\n",
^~~
cdev
drivers/net/ethernet/cavium/thunder/nicvf_main.c:1596:15: note: each undeclared identifier is reported only once for each function it appears in
prev parent reply other threads:[~2019-04-11 2:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 21:06 [PATCH net v2 0/2] Fix thunderx MTU with XDP Matteo Croce
2019-04-08 21:06 ` [PATCH net v2 1/2] net: thunderx: raise XDP MTU to 1508 Matteo Croce
2019-04-08 21:06 ` [PATCH net v2 2/2] net: thunderx: don't allow jumbo frames with XDP Matteo Croce
2019-04-11 2:35 ` [PATCH net v2 0/2] Fix thunderx MTU " David Miller
2019-04-11 2:35 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190410.193545.867822076372319682.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=brouer@redhat.com \
--cc=ilias.apalodimas@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mcroce@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rric@kernel.org \
--cc=sgoutham@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).