From: Huang Rui <huangruippp@gmail.com>
To: davem@davemloft.net
Cc: ast@kernel.org, daniel@iogearbox.net,
jakub.kicinski@netronome.com, hawk@kernel.org,
john.fastabend@gmail.com, kafai@fb.com, songliubraving@fb.com,
yhs@fb.com, jiri@mellanox.com, ecree@solarflare.com,
idosch@mellanox.com, petrm@mellanox.com,
alexander.h.duyck@intel.com, amritha.nambiar@intel.com,
lirongqing@baidu.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, xdp-newbies@vger.kernel.org,
bpf@vger.kernel.org, roopa@cumulusnetworks.com,
nikolay@cumulusnetworks.com, bridge@lists.linux-foundation.org,
huangruiPPP@gmail.com
Subject: [PATCH] net:bridge:always disable auto-tuning when the user specified MTU
Date: Wed, 10 Apr 2019 02:32:08 +0000 [thread overview]
Message-ID: <20190410023208.25435-1-huangruiPPP@gmail.com> (raw)
For example.
My purpose is to create a bridge br0 and join eth0 into br0.
if we use this following way, the auto-tuning flag will not be disabled.
If eth0's mtu is 1200
step 1.brctl addbr br0
step 2.brctl addif br0 eth0
step 3.ifconfig br0 mtu 1200
step 4.ifconfig eth0 mtu 1500
Result:
br0's MTU: 1500, eth0's MTU: 1500
Expected:
br0's MTU: 1200, eth0's MTU: 1500
I have specified br0's MTU, but auto-min policy works. So the MTU is
not the result what we expected.
As expected, if i have specified bridge's MTU, it will set the flag:
BROPT_MTU_SET_BY_USER in net_bridge_opts disabled and auto-min/max
policy will not work.But in this case, because the dev_set_mtu return
early, the BROPT_MTU_SET_BY_USER flag will not be disabled and
auto-min/max policy will still work.
Signed-off-by: Huang Rui <huangruiPPP@gmail.com>
---
net/core/dev.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/net/core/dev.c b/net/core/dev.c
index 2b67f2aa59dd..ba410d76bb49 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -7670,8 +7670,12 @@ int dev_set_mtu_ext(struct net_device *dev, int new_mtu,
{
int err, orig_mtu;
- if (new_mtu == dev->mtu)
- return 0;
+ if (new_mtu == dev->mtu) {
+ if (dev->priv_flags & IFF_EBRIDGE)
+ return __dev_set_mtu(dev, new_mtu);
+ else
+ return 0;
+ }
/* MTU must be positive, and in range */
if (new_mtu < 0 || new_mtu < dev->min_mtu) {
--
2.11.0
next reply other threads:[~2019-04-10 2:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-10 2:32 Huang Rui [this message]
2019-04-10 2:39 ` [PATCH] net:bridge:always disable auto-tuning when the user specified MTU Stephen Hemminger
2019-04-10 10:34 ` Petr Machata
2019-04-10 11:05 ` Nikolay Aleksandrov
2019-04-16 7:19 ` 黄睿
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190410023208.25435-1-huangruiPPP@gmail.com \
--to=huangruippp@gmail.com \
--cc=alexander.h.duyck@intel.com \
--cc=amritha.nambiar@intel.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=bridge@lists.linux-foundation.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=ecree@solarflare.com \
--cc=hawk@kernel.org \
--cc=idosch@mellanox.com \
--cc=jakub.kicinski@netronome.com \
--cc=jiri@mellanox.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lirongqing@baidu.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=petrm@mellanox.com \
--cc=roopa@cumulusnetworks.com \
--cc=songliubraving@fb.com \
--cc=xdp-newbies@vger.kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).