From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01881C10F11 for ; Wed, 10 Apr 2019 13:39:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BA6CE20850 for ; Wed, 10 Apr 2019 13:39:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="x3UqJfFL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731494AbfDJNjt (ORCPT ); Wed, 10 Apr 2019 09:39:49 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:40555 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730167AbfDJNjr (ORCPT ); Wed, 10 Apr 2019 09:39:47 -0400 Received: by mail-wr1-f65.google.com with SMTP id h4so2992266wre.7 for ; Wed, 10 Apr 2019 06:39:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=NT7PU604I95vfdXNoejERAIVydJjJVvO8XfoMsefVP4=; b=x3UqJfFLD5fvWWfOMpEHCrnXcJhpGO632jXePwPnd820jjWJouNkhdMbAJAxmv9/VO /uCW/xwAgyMe3SRl+4DqNGTCb1fkuw4ccx07rYCttX6HEnATI6uqvLKidchcqXYM54h0 oPW4Tn+INYx+ttogS7YBKhGhZRTw/0/iENM5JETsV1cvYY8eY+Gygcphw6YmtpKBKFY+ rysifup7YDlLtNRM7vygTuR3VP19VU8vT7wO9Gs7pM/oVNmoKfsRTnRGHO3u97ghIHU6 1NqC/8xMc1ogwcp2gO9JgNyaeGnytwVb6mZiHqc/U2PEiiGUTp/N4KfvlohvSQwA3sQx CFEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=NT7PU604I95vfdXNoejERAIVydJjJVvO8XfoMsefVP4=; b=AqemKjDYsT7olmM2JONRpq/d3+GGkcBnVWFLIBPPxlbnAS4xmnJGTNm7myjvpMkmwD w2QqA+C9RA5yWdslsGqFPEpLkrugftWNv8DCwe2p5YGwUCLgNeDA6fyzRwD+Ob5btwkZ PoFNqNBizXdJfn2gI9lQwTS0fCWi41JVWbq1BsMKKtQ/rQScncGVFwwywajaiz9izn4Y hj0ix45RXXiRmNQHzJQ+/ZX1rSgACZOcJbLbIJIAWkWhBgaiwWFQRDUmyYI+UEMndIXx a4CQK1Vk9tL7ITnoL6WBGgGPUUZrvxXnegjcy26e2BA5sAx3lg6nEcUPruPtf/Aa1FHc 7Dkg== X-Gm-Message-State: APjAAAXcXXQ+bkXpXANNzhz5Nls8IdMtHf5hw5WyO3t1QlRAV1DH+PpX SohzVgK8IkmTZXAX5frptkRJSA== X-Google-Smtp-Source: APXvYqy7+ZHFok/3XIr2rdVnasJp387OigzHSjP6xtzz7MHYUQcKX16clItKLpE1AvvQrl7440Au+A== X-Received: by 2002:a5d:4f07:: with SMTP id c7mr27437846wru.104.1554903585706; Wed, 10 Apr 2019 06:39:45 -0700 (PDT) Received: from localhost (mail.chocen-mesto.cz. [85.163.43.2]) by smtp.gmail.com with ESMTPSA id z140sm6978655wmc.27.2019.04.10.06.39.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 10 Apr 2019 06:39:44 -0700 (PDT) Date: Wed, 10 Apr 2019 15:39:44 +0200 From: Jiri Pirko To: Ido Schimmel Cc: "netdev@vger.kernel.org" , "davem@davemloft.net" , Jiri Pirko , mlxsw Subject: Re: [PATCH net 1/7] mlxsw: spectrum_switchdev: Add MDB entries in prepare phase Message-ID: <20190410133944.GB2130@nanopsycho> References: <20190410065758.21199-1-idosch@mellanox.com> <20190410065758.21199-2-idosch@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190410065758.21199-2-idosch@mellanox.com> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Wed, Apr 10, 2019 at 08:58:12AM CEST, idosch@mellanox.com wrote: >The driver cannot guarantee in the prepare phase that it will be able to >write an MDB entry to the device. In case the driver returned success >during the prepare phase, but then failed to add the entry in the commit >phase, a WARNING [1] will be generated by the switchdev core. > >Fix this by doing the work in the prepare phase instead. > >[1] >[ 358.544486] swp12s0: Commit of object (id=2) failed. >[ 358.550061] WARNING: CPU: 0 PID: 30 at net/switchdev/switchdev.c:281 switchdev_port_obj_add_now+0x9b/0xe0 >[ 358.560754] CPU: 0 PID: 30 Comm: kworker/0:1 Not tainted 5.0.0-custom-13382-gf2449babf221 #1350 >[ 358.570472] Hardware name: Mellanox Technologies Ltd. MSN2100-CB2FO/SA001017, BIOS 5.6.5 06/07/2016 >[ 358.580582] Workqueue: events switchdev_deferred_process_work >[ 358.587001] RIP: 0010:switchdev_port_obj_add_now+0x9b/0xe0 >... >[ 358.614109] RSP: 0018:ffffa6b900d6fe18 EFLAGS: 00010286 >[ 358.619943] RAX: 0000000000000000 RBX: ffff8b00797ff000 RCX: 0000000000000000 >[ 358.627912] RDX: ffff8b00b7a1d4c0 RSI: ffff8b00b7a152e8 RDI: ffff8b00b7a152e8 >[ 358.635881] RBP: ffff8b005c3f5bc0 R08: 000000000000022b R09: 0000000000000000 >[ 358.643850] R10: 0000000000000000 R11: ffffa6b900d6fcc8 R12: 0000000000000000 >[ 358.651819] R13: dead000000000100 R14: ffff8b00b65a23c0 R15: 0ffff8b00b7a2200 >[ 358.659790] FS: 0000000000000000(0000) GS:ffff8b00b7a00000(0000) knlGS:0000000000000000 >[ 358.668820] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 >[ 358.675228] CR2: 00007f00aad90de0 CR3: 00000001ca80d000 CR4: 00000000001006f0 >[ 358.683188] Call Trace: >[ 358.685918] switchdev_port_obj_add_deferred+0x13/0x60 >[ 358.691655] switchdev_deferred_process+0x6b/0xf0 >[ 358.696907] switchdev_deferred_process_work+0xa/0x10 >[ 358.702548] process_one_work+0x1f5/0x3f0 >[ 358.707022] worker_thread+0x28/0x3c0 >[ 358.711099] ? process_one_work+0x3f0/0x3f0 >[ 358.715768] kthread+0x10d/0x130 >[ 358.719369] ? __kthread_create_on_node+0x180/0x180 >[ 358.724815] ret_from_fork+0x35/0x40 > >Fixes: 3a49b4fde2a1 ("mlxsw: Adding layer 2 multicast support") >Signed-off-by: Ido Schimmel >Reported-by: Alex Kushnarov >Tested-by: Alex Kushnarov Acked-by: Jiri Pirko