From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E3B1C10F11 for ; Wed, 10 Apr 2019 13:40:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E103020854 for ; Wed, 10 Apr 2019 13:40:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="x4+/kq75" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731329AbfDJNkv (ORCPT ); Wed, 10 Apr 2019 09:40:51 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:38903 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729140AbfDJNku (ORCPT ); Wed, 10 Apr 2019 09:40:50 -0400 Received: by mail-wr1-f67.google.com with SMTP id k11so3018692wro.5 for ; Wed, 10 Apr 2019 06:40:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=zcp0w+EHTsisi7FnxwWDVEm4bCAgCsm+RV0nHD1v0H8=; b=x4+/kq75e2kIw2Twq2prOxKKlTSHPIMtsC1rXgt+TPd/kmq4P/KTTJW23/m3pp3j+c E1JylQI5vVZ40VKx5myvHn85DyoTUPTVLJJEjZ0eI2cv761pXHIBYtGvFXaKLDxWJh4b l8SaRApI5HLNb8k5lQ8Y73SV0Nx7iQpEJziA6WpDl/SkGoOF+DBGWy/38zmdCG++a98J 6a3Nl/8IT5aVA01KKZG8mZiKdey3vhazwrckGr4p3nSFVka5bFrES9Y7rQdQvrySIfVT 4Kh+c5iloaEyN5D7iybAIVzAfyjizquf+nDlZ5etk9B+phkMEGkyPVzFJXVHdnI8WuZo rwXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=zcp0w+EHTsisi7FnxwWDVEm4bCAgCsm+RV0nHD1v0H8=; b=mIemgMBLGOyQMEH7wESNbFWwQPzbu9PrTFJiRGS/05U/iz9hv2QXMw8aTEAQ8roP8O 5SQOj5QsewbGmBTYa5ww6Zr8AmxE1Muk7gcsASeHoco9HGk1E0hx/O1o1pWbTw6qkFyB G7ueE3hHK/OeoNPzKuK6yI9/7txXnHj1nviaygSMFT6Rrlcpgaak5ZZSup4LSBUlY4j5 UjSF4eDYYaiR3svpEiTsDAjXIsevH2RaX+rZLX5q2hQXL2mSjHl2abtlPy7cum/OEvSB QsvhTL73T1HM6/E/pMNV3clV0oolfG5kp6Zrhccg6sH8LQy+gnQTTpY4WXJQnDfZBAsj WbOA== X-Gm-Message-State: APjAAAWEn0RTiAdRHyOVHVCNiVjdRxlVep1BQDxsWm/L8o1lnu3IaMiD VHMpixd97dld4ODnLnOH8WhHjg== X-Google-Smtp-Source: APXvYqzNaeqVogwTnijeVBh2YGZJBzf/dlIE3AHKX76YQVRpz/0InzcOYqNMbVIhQvSTDU6GR1Ox4A== X-Received: by 2002:adf:f3ce:: with SMTP id g14mr26646606wrp.129.1554903648687; Wed, 10 Apr 2019 06:40:48 -0700 (PDT) Received: from localhost (mail.chocen-mesto.cz. [85.163.43.2]) by smtp.gmail.com with ESMTPSA id k9sm47232086wru.55.2019.04.10.06.40.48 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 10 Apr 2019 06:40:48 -0700 (PDT) Date: Wed, 10 Apr 2019 15:40:47 +0200 From: Jiri Pirko To: Ido Schimmel Cc: "netdev@vger.kernel.org" , "davem@davemloft.net" , Jiri Pirko , mlxsw Subject: Re: [PATCH net 7/7] mlxsw: spectrum_buffers: Add a multicast pool for Spectrum-2 Message-ID: <20190410134047.GC2130@nanopsycho> References: <20190410065758.21199-1-idosch@mellanox.com> <20190410065758.21199-8-idosch@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190410065758.21199-8-idosch@mellanox.com> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Wed, Apr 10, 2019 at 08:58:17AM CEST, idosch@mellanox.com wrote: >In Spectrum-1, when a multicast packet is admitted to the shared buffer >it increases the quotas of all the ports and {port, TC} to which it is >forwarded to. > >The above means that multicast packets are accounted multiple times in >the shared buffer and can therefore cause the associated shared buffer >pool to fill up very quickly. > >To work around this issue, commit e83c045e53d7 ("mlxsw: >spectrum_buffers: Configure MC pool") added a dedicated multicast pool >in which multicast packets are accounted. > >The issue is not present in Spectrum-2, but in order to be backward >compatible with Spectrum-1, its default behavior is to allow a multicast >packet to increase multiple egress quotas instead of one. > >Until the new (non-backward compatible) mode is supported, configure a >dedicated multicast pool as in Spectrum-1. > >Fixes: fe099bf682ab ("mlxsw: spectrum_buffers: Add Spectrum-2 shared buffer configuration") >Signed-off-by: Ido Schimmel >Reviewed-by: Petr Machata Acked-by: Jiri Pirko