From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86878C10F13 for ; Thu, 11 Apr 2019 21:18:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5D75B2184B for ; Thu, 11 Apr 2019 21:18:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726785AbfDKVSY (ORCPT ); Thu, 11 Apr 2019 17:18:24 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:35260 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726577AbfDKVSY (ORCPT ); Thu, 11 Apr 2019 17:18:24 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id C191414D3911E; Thu, 11 Apr 2019 14:18:23 -0700 (PDT) Date: Thu, 11 Apr 2019 14:18:23 -0700 (PDT) Message-Id: <20190411.141823.1468157210604234195.davem@davemloft.net> To: dsahern@kernel.org Cc: netdev@vger.kernel.org, dsahern@gmail.com Subject: Re: [PATCH net] selftests: fib_tests: Fix 'Command line is not complete' errors From: David Miller In-Reply-To: <20190409212310.14988-1-dsahern@kernel.org> References: <20190409212310.14988-1-dsahern@kernel.org> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 11 Apr 2019 14:18:23 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: David Ahern Date: Tue, 9 Apr 2019 14:23:10 -0700 > From: David Ahern > > A couple of tests are verifying a route has been removed. The helper > expects the prefix as the first part of the expected output. When > checking that a route has been deleted the prefix is empty leading > to an invalid ip command: > > $ ip ro ls match > Command line is not complete. Try option "help" > > Fix by moving the comparison of expected output and output to a new > function that is used by both check_route and check_route6. Use the > new helper for the 2 checks on route removal. > > Also, remove the reset of 'set -x' in route_setup which overrides the > user managed setting. > > Fixes: d69faad76584c ("selftests: fib_tests: Add prefix route tests with metric") > Signed-off-by: David Ahern Applied.