From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5470EC10F13 for ; Thu, 11 Apr 2019 13:04:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 229432133D for ; Thu, 11 Apr 2019 13:04:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726676AbfDKNEl (ORCPT ); Thu, 11 Apr 2019 09:04:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38556 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726121AbfDKNEk (ORCPT ); Thu, 11 Apr 2019 09:04:40 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8D76423E6C9; Thu, 11 Apr 2019 13:04:40 +0000 (UTC) Received: from carbon (ovpn-200-23.brq.redhat.com [10.40.200.23]) by smtp.corp.redhat.com (Postfix) with ESMTP id 90D191001E67; Thu, 11 Apr 2019 13:04:33 +0000 (UTC) Date: Thu, 11 Apr 2019 15:04:32 +0200 From: Jesper Dangaard Brouer To: Matteo Croce Cc: netdev@vger.kernel.org, Sunil Goutham , Robert Richter , linux-arm-kernel@lists.infradead.org, Ilias Apalodimas , David Miller , brouer@redhat.com Subject: Re: [PATCH v3 1/2] net: thunderx: raise XDP MTU to 1508 Message-ID: <20190411150432.72882c56@carbon> In-Reply-To: <20190411102633.3685-2-mcroce@redhat.com> References: <20190411102633.3685-1-mcroce@redhat.com> <20190411102633.3685-2-mcroce@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Thu, 11 Apr 2019 13:04:40 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 11 Apr 2019 12:26:32 +0200 Matteo Croce wrote: > The thunderx driver splits frames bigger than 1530 bytes to multiple > pages, making impossible to run an eBPF program on it. > This leads to a maximum MTU of 1508 if QinQ is in use. > > The thunderx driver forbids to load an eBPF program if the MTU is higher > than 1500 bytes. Raise the limit to 1508 so it is possible to use L2 > protocols which need some more headroom. > > Fixes: 05c773f52b96e ("net: thunderx: Add basic XDP support") > Signed-off-by: Matteo Croce > --- > drivers/net/ethernet/cavium/thunder/nicvf_main.c | 13 +++++++++++-- > 1 file changed, 11 insertions(+), 2 deletions(-) LGTM Acked-by: Jesper Dangaard Brouer -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer