From: Stefano Brivio <sbrivio@redhat.com>
To: David Ahern <dsahern@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH v2 net-next] selftests: Add debugging options to pmtu.sh
Date: Thu, 11 Apr 2019 21:04:15 +0200 [thread overview]
Message-ID: <20190411210415.1ba9acf1@redhat.com> (raw)
In-Reply-To: <20190411185150.29570-1-dsahern@kernel.org>
On Thu, 11 Apr 2019 11:51:50 -0700
David Ahern <dsahern@kernel.org> wrote:
> From: David Ahern <dsahern@gmail.com>
>
> pmtu.sh script runs a number of tests and dumps a summary of pass/fail.
> If a test fails, it is near impossible to debug why. For example:
>
> TEST: ipv6: PMTU exceptions [FAIL]
>
> There are a lot of commands run behind the scenes for this test. Which
> one is failing?
>
> Add a VERBOSE option to show commands that are run and any output from
> those commands. Add a PAUSE_ON_FAIL option to halt the script if a test
> fails allowing users to poke around with the setup in the failed state.
>
> In the process, rename tracing to TRACING and move declaration to top
> with the new variables.
>
> Signed-off-by: David Ahern <dsahern@gmail.com>
> ---
> v2
> - moved tracing to TRACING, dropped eval and quoted command in new run_cmd,
> dropped local from declarations - all comments from Stefano
Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
--
Stefano
prev parent reply other threads:[~2019-04-11 19:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-11 18:51 [PATCH v2 net-next] selftests: Add debugging options to pmtu.sh David Ahern
2019-04-11 19:04 ` Stefano Brivio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190411210415.1ba9acf1@redhat.com \
--to=sbrivio@redhat.com \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=dsahern@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).