From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DC3FC10F13 for ; Thu, 11 Apr 2019 19:04:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2482820651 for ; Thu, 11 Apr 2019 19:04:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726748AbfDKTEU (ORCPT ); Thu, 11 Apr 2019 15:04:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37404 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726577AbfDKTEU (ORCPT ); Thu, 11 Apr 2019 15:04:20 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9EE517DCE7; Thu, 11 Apr 2019 19:04:20 +0000 (UTC) Received: from localhost (ovpn-200-45.brq.redhat.com [10.40.200.45]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E695C5D9C8; Thu, 11 Apr 2019 19:04:18 +0000 (UTC) Date: Thu, 11 Apr 2019 21:04:15 +0200 From: Stefano Brivio To: David Ahern Cc: davem@davemloft.net, netdev@vger.kernel.org, David Ahern Subject: Re: [PATCH v2 net-next] selftests: Add debugging options to pmtu.sh Message-ID: <20190411210415.1ba9acf1@redhat.com> In-Reply-To: <20190411185150.29570-1-dsahern@kernel.org> References: <20190411185150.29570-1-dsahern@kernel.org> Organization: Red Hat MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Thu, 11 Apr 2019 19:04:20 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 11 Apr 2019 11:51:50 -0700 David Ahern wrote: > From: David Ahern > > pmtu.sh script runs a number of tests and dumps a summary of pass/fail. > If a test fails, it is near impossible to debug why. For example: > > TEST: ipv6: PMTU exceptions [FAIL] > > There are a lot of commands run behind the scenes for this test. Which > one is failing? > > Add a VERBOSE option to show commands that are run and any output from > those commands. Add a PAUSE_ON_FAIL option to halt the script if a test > fails allowing users to poke around with the setup in the failed state. > > In the process, rename tracing to TRACING and move declaration to top > with the new variables. > > Signed-off-by: David Ahern > --- > v2 > - moved tracing to TRACING, dropped eval and quoted command in new run_cmd, > dropped local from declarations - all comments from Stefano Reviewed-by: Stefano Brivio -- Stefano