From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4087C10F13 for ; Thu, 11 Apr 2019 22:17:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AAAAE2146F for ; Thu, 11 Apr 2019 22:17:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="p0RN8gGn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726735AbfDKWRt (ORCPT ); Thu, 11 Apr 2019 18:17:49 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:51402 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726633AbfDKWRt (ORCPT ); Thu, 11 Apr 2019 18:17:49 -0400 Received: by mail-wm1-f65.google.com with SMTP id 4so8675787wmf.1 for ; Thu, 11 Apr 2019 15:17:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=VWnzyvXyuZDsykWfWXKCv4NhhyTEEVvpMMqAJ5Jbe2o=; b=p0RN8gGn4jMlC+GqElKmcGB18y6FTqGtCpV7rlaJuQfIE036gDybpArSIiVBuZoeH0 jyCjlzv+jBTTcFJECPV4Eg7vRn4m1+N7tC2kJjRmH5Z86nM3PsLxsWhXy0BPQjRljfm2 XiZUBFtkk/61bZ3mQVSkZpMXr3cNCtavIx9BDJ2pODxV+E+q/gXeWbOgfjWMbsHewEK8 4nFF0wy4TntKDGl8GD0cnRTvWTDRV9MENJ9mdIQzNZezCZHWtad/x9Bx+j9KE7geEljD AyGtRsNFc4nPLR2V2vfBof6dJkdOpzSybXFxmEbD/yR8ZKd/UBg76w3lVkdx36YQ+OO6 m2/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=VWnzyvXyuZDsykWfWXKCv4NhhyTEEVvpMMqAJ5Jbe2o=; b=IWnFZTTjqWqsxJCT+TYW46CRkNkwB+PiWgYpZ0WD+E5+oJdwMCJzkwrd7aQtf7zIod RxNwBYlaa3jUjIoXUxq1EhLfqLKL62b6uDeofBT2oVkVHhR3DX9Djrp5SRAB8ZvCe8AS 6mqgFtvvYMtI6tyUAJpo2VPzkHKjZj7oljBQZZSSuJfDD336Igl50CgGhFMB4hk6IZx7 F/pW+ZOynP2PeuTkGsexnYLN5+I5FXJulRIrgP2IJkGJedK/dZ0ppXTg1i+WGmuPGTB/ l4lZ55QTZuIE1okfX5dk4IuzpeKF8/BZopClvGozp/5WSXpcZVKNIOeaGMDaXGUOCDZR SOzA== X-Gm-Message-State: APjAAAXYjDPJps3SR1cz8JBHEuz+nIw4239k3ekrouNzK6jUPZgBT3Le pXA0C+FpXfkjV3aN6LSTQ+U= X-Google-Smtp-Source: APXvYqyQFd9tcVy3Rev46cFvGZZhdg/KpMAb4Srfa4j11+8Npu79bFOr7rrWRSMSC412E1q1Xr5FYw== X-Received: by 2002:a05:600c:24f:: with SMTP id 15mr8603191wmj.48.1555021067223; Thu, 11 Apr 2019 15:17:47 -0700 (PDT) Received: from localhost.localdomain ([194.42.141.29]) by smtp.gmail.com with ESMTPSA id d16sm31414736wrs.68.2019.04.11.15.17.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 11 Apr 2019 15:17:46 -0700 (PDT) Received: by localhost.localdomain (Postfix, from userid 1000) id 962E0180B5B; Thu, 11 Apr 2019 19:17:44 -0300 (-03) Date: Thu, 11 Apr 2019 19:17:44 -0300 From: Marcelo Ricardo Leitner To: David Miller Cc: netdev@vger.kernel.org, lucien.xin@gmail.com, nhorman@tuxdriver.com Subject: Re: [PATCH v5 1/5] sctp: Remove superfluous test in sctp_ulpq_reasm_drain(). Message-ID: <20190411221744.GM10452@localhost.localdomain> References: <20190411.150153.218246264497327400.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190411.150153.218246264497327400.davem@davemloft.net> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Apr 11, 2019 at 03:01:53PM -0700, David Miller wrote: > > Inside the loop, we always start with event non-NULL. > > Signed-off-by: David S. Miller Acked-by: Marcelo Ricardo Leitner > --- > net/sctp/ulpqueue.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/sctp/ulpqueue.c b/net/sctp/ulpqueue.c > index 5dde92101743..0fecc1fb4ab7 100644 > --- a/net/sctp/ulpqueue.c > +++ b/net/sctp/ulpqueue.c > @@ -745,7 +745,7 @@ static void sctp_ulpq_reasm_drain(struct sctp_ulpq *ulpq) > > while ((event = sctp_ulpq_retrieve_reassembled(ulpq)) != NULL) { > /* Do ordering if needed. */ > - if ((event) && (event->msg_flags & MSG_EOR)) { > + if (event->msg_flags & MSG_EOR) { > skb_queue_head_init(&temp); > __skb_queue_tail(&temp, sctp_event2skb(event)); > > -- > 2.20.1 >