From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04AF8C10F13 for ; Thu, 11 Apr 2019 22:18:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B6FEF2146F for ; Thu, 11 Apr 2019 22:18:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="p9StLqej" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726867AbfDKWSP (ORCPT ); Thu, 11 Apr 2019 18:18:15 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:44590 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726633AbfDKWSP (ORCPT ); Thu, 11 Apr 2019 18:18:15 -0400 Received: by mail-wr1-f68.google.com with SMTP id y7so9313845wrn.11 for ; Thu, 11 Apr 2019 15:18:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=a6lVdGIAkJi+MloGRDNaSNDUkIlxUZAf5h+KZDBlGI0=; b=p9StLqejHSx7Tfh6pp5yDZ9VXTK/jZYVghvQzOBxg5mSrlNutFST1Lc+/vZsbJ82NP /zD2juBhgX/XGyp7XMYl6uEGBwLoyhMyBfejpj8hpI0CRJ+5jxuGbpC8uUqWhWYowIFa 5NpOU9oj5m+c+oolz8IuQ+Mr3iDEmQOJMdkV/uGGgo29NNW9Wfj+QrcOSAC2HAaIamqq WUM74ZjshfTSB4SAL37UG0hD16BePnJK12sYvI3iAynAWWHDAUodiUACRxIwp3dczxRI zsNVQgAer7+El5vMei4ccmtV71A7EbTvnDs9eD7bCAvwRkTD08KBsU+MnWZkfwx7kEvJ GBTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=a6lVdGIAkJi+MloGRDNaSNDUkIlxUZAf5h+KZDBlGI0=; b=m0gtlgek0V0c2ElzwEA11xkBJQacUTfT6A4O+xd2CsqOxBgM+ejSrJV4qetamLqn9j 0bKOq407OumJ9yrQ5jAYYUWgiS92rzerazvkw39qooCuO8sHgqpkgqbtmdysybQrl2WO m4ahUZulxN5R4yOkIJpEWX9l7OM4NUL1TQe0lTNK7jqMKhkSYInCOXcd6AjR2UVIqHZh 5dQQdPXrpch/+VKtQ/NCBvt+q6vjS/QY+6pdyhp0MxxIHQ2lxOj90PV6gGbwwiMdim5D OFH6fO9DxfJALXGEeSK+c/xPHWu3mO6/pMLAq62rIs4GKtc7AUlxdAElFPCFxi1YycOG P0vg== X-Gm-Message-State: APjAAAV3Mdu13qrJ6bSCgCNprsUQVCFREfQxfnOEM3ZLgTatMJeaE0h/ KjcqfXPjjEKNYZ1dw487lRM= X-Google-Smtp-Source: APXvYqzo6WA8MtSuvODtLtEjow7h/YzUOcqJRFoLa5zEi4m+5pIABsH3m032O7Awx5+0GfrEmYDgEQ== X-Received: by 2002:adf:edca:: with SMTP id v10mr4380718wro.157.1555021093593; Thu, 11 Apr 2019 15:18:13 -0700 (PDT) Received: from localhost.localdomain ([194.42.141.29]) by smtp.gmail.com with ESMTPSA id v190sm10101977wme.18.2019.04.11.15.18.12 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 11 Apr 2019 15:18:13 -0700 (PDT) Received: by localhost.localdomain (Postfix, from userid 1000) id 66A78180B5B; Thu, 11 Apr 2019 19:18:11 -0300 (-03) Date: Thu, 11 Apr 2019 19:18:11 -0300 From: Marcelo Ricardo Leitner To: David Miller Cc: netdev@vger.kernel.org, lucien.xin@gmail.com, nhorman@tuxdriver.com Subject: Re: [PATCH v5 3/5] sctp: Use helper for sctp_ulpq_tail_event() when hooked up to ->enqueue_event Message-ID: <20190411221811.GO10452@localhost.localdomain> References: <20190411.150201.46148653005422499.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190411.150201.46148653005422499.davem@davemloft.net> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Apr 11, 2019 at 03:02:01PM -0700, David Miller wrote: > > This way we can make sure events sent this way to > sctp_ulpq_tail_event() are on a list as well. Now all such code paths > are fully covered. > > Signed-off-by: David S. Miller Acked-by: Marcelo Ricardo Leitner > --- > net/sctp/stream_interleave.c | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/net/sctp/stream_interleave.c b/net/sctp/stream_interleave.c > index 102c6fefe38c..a6bc42121e35 100644 > --- a/net/sctp/stream_interleave.c > +++ b/net/sctp/stream_interleave.c > @@ -1298,6 +1298,15 @@ static void sctp_handle_iftsn(struct sctp_ulpq *ulpq, struct sctp_chunk *chunk) > ntohl(skip->mid), skip->flags); > } > > +static int do_ulpq_tail_event(struct sctp_ulpq *ulpq, struct sctp_ulpevent *event) > +{ > + struct sk_buff_head temp; > + > + skb_queue_head_init(&temp); > + __skb_queue_tail(&temp, sctp_event2skb(event)); > + return sctp_ulpq_tail_event(ulpq, event); > +} > + > static struct sctp_stream_interleave sctp_stream_interleave_0 = { > .data_chunk_len = sizeof(struct sctp_data_chunk), > .ftsn_chunk_len = sizeof(struct sctp_fwdtsn_chunk), > @@ -1306,7 +1315,7 @@ static struct sctp_stream_interleave sctp_stream_interleave_0 = { > .assign_number = sctp_chunk_assign_ssn, > .validate_data = sctp_validate_data, > .ulpevent_data = sctp_ulpq_tail_data, > - .enqueue_event = sctp_ulpq_tail_event, > + .enqueue_event = do_ulpq_tail_event, > .renege_events = sctp_ulpq_renege, > .start_pd = sctp_ulpq_partial_delivery, > .abort_pd = sctp_ulpq_abort_pd, > -- > 2.20.1 >