From: kbuild test robot <lkp@intel.com>
To: Atul Gupta <atul.gupta@chelsio.com>
Cc: kbuild-all@01.org, herbert@gondor.apana.org.au,
davem@davemloft.net, linux-crypto@vger.kernel.org,
netdev@vger.kernel.org, dt@chelsio.com, atul.gupta@chelsio.com
Subject: Re: [crypto 2/4] crypto/chelsio/chtls: hardware connect API
Date: Fri, 12 Apr 2019 12:30:28 +0800 [thread overview]
Message-ID: <201904121251.mCUeLNQa%lkp@intel.com> (raw)
In-Reply-To: <20190409152342.11200-1-atul.gupta@chelsio.com>
Hi Atul,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on crypto/master]
url: https://github.com/0day-ci/linux/commits/Atul-Gupta/Inline-TLS-client-and-v6-support/20190412-034407
base: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git master
reproduce:
# apt-get install sparse
make ARCH=x86_64 allmodconfig
make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
sparse warnings: (new ones prefixed by >>)
>> drivers/crypto/chelsio/chtls/chtls_cm.c:1254:42: sparse: incorrect type in assignment (different base types) @@ expected restricted __be32 [usertype] atid_status @@ got e] atid_status @@
drivers/crypto/chelsio/chtls/chtls_cm.c:1254:42: expected restricted __be32 [usertype] atid_status
drivers/crypto/chelsio/chtls/chtls_cm.c:1254:42: got int
drivers/crypto/chelsio/chtls/chtls_cm.c:1076:17: sparse: expression using sizeof(void)
>> drivers/crypto/chelsio/chtls/chtls_cm.c:1272:40: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct socket_wq *wq @@ got struct socket_wq struct socket_wq *wq @@
drivers/crypto/chelsio/chtls/chtls_cm.c:1272:40: expected struct socket_wq *wq
drivers/crypto/chelsio/chtls/chtls_cm.c:1272:40: got struct socket_wq [noderef] <asn:4>*sk_wq
>> drivers/crypto/chelsio/chtls/chtls_cm.c:1273:25: sparse: cast to restricted __poll_t
drivers/crypto/chelsio/chtls/chtls_cm.c:1320:16: sparse: expression using sizeof(void)
>> drivers/crypto/chelsio/chtls/chtls_cm.c:1470:60: sparse: Using plain integer as NULL pointer
drivers/crypto/chelsio/chtls/chtls_cm.c:1573:22: sparse: context imbalance in 'chtls_recv_sock' - unexpected unlock
vim +1254 drivers/crypto/chelsio/chtls/chtls_cm.c
1239
1240 static void chtls_connect_req_arp_failure(void *handle, struct sk_buff *skb)
1241 {
1242 struct sock *sk = skb->sk;
1243
1244 sock_hold(sk);
1245 bh_lock_sock(sk);
1246 if (sk->sk_state == TCP_SYN_SENT || sk->sk_state == TCP_SYN_RECV) {
1247 if (!sock_owned_by_user(sk)) {
1248 chtls_act_open_fail(sk, EHOSTUNREACH);
1249 __kfree_skb(skb);
1250 } else {
1251 struct cpl_act_open_rpl *rpl = cplhdr(skb) + RSS_HDR;
1252
1253 rpl->ot.opcode = CPL_ACT_OPEN_RPL;
> 1254 rpl->atid_status = CPL_ERR_ARP_MISS;
1255 BLOG_SKB_CB(skb)->backlog_rcv = chtls_active_open_rpl;
1256 __sk_add_backlog(sk, skb);
1257 }
1258 }
1259 bh_unlock_sock(sk);
1260 sock_put(sk);
1261 }
1262
1263 static void chtls_write_space(struct sock *sk)
1264 {
1265 struct socket *sock = sk->sk_socket;
1266 struct socket_wq *wq;
1267
1268 if (sk_stream_wspace(sk) >= sk_stream_min_wspace(sk) && sock) {
1269 clear_bit(SOCK_NOSPACE, &sock->flags);
1270 rcu_read_lock();
1271 wq = rcu_dereference(sk->sk_wq);
> 1272 if (skwq_has_sleeper(sk->sk_wq))
> 1273 wake_up_interruptible_poll(&wq->wait, POLLOUT |
1274 POLLWRNORM |
1275 POLLWRBAND);
1276 if (wq && wq->fasync_list && !(sk->sk_shutdown & SEND_SHUTDOWN))
1277 sock_wake_async(wq, SOCK_WAKE_SPACE, POLL_OUT);
1278 rcu_read_unlock();
1279 }
1280 }
1281
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
prev parent reply other threads:[~2019-04-12 4:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-09 15:23 [crypto 2/4] crypto/chelsio/chtls: hardware connect API Atul Gupta
2019-04-12 4:30 ` kbuild test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201904121251.mCUeLNQa%lkp@intel.com \
--to=lkp@intel.com \
--cc=atul.gupta@chelsio.com \
--cc=davem@davemloft.net \
--cc=dt@chelsio.com \
--cc=herbert@gondor.apana.org.au \
--cc=kbuild-all@01.org \
--cc=linux-crypto@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).