* [PATCH net-next] ipv6: Remove flowi6_oif compare from __ip6_route_redirect
@ 2019-04-12 17:31 David Ahern
2019-04-13 0:05 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: David Ahern @ 2019-04-12 17:31 UTC (permalink / raw)
To: davem; +Cc: netdev, David Ahern
From: David Ahern <dsahern@gmail.com>
In the review of 0b34eb004347 ("ipv6: Refactor __ip6_route_redirect"),
Martin noted that the flowi6_oif compare is moved to the new helper and
should be removed from __ip6_route_redirect. Fix the oversight.
Fixes: 0b34eb004347 ("ipv6: Refactor __ip6_route_redirect")
Reported-by: Martin Lau <kafai@fb.com>
Signed-off-by: David Ahern <dsahern@gmail.com>
---
net/ipv6/route.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index d555edaaff13..a77c004d67fb 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -2471,8 +2471,6 @@ static struct rt6_info *__ip6_route_redirect(struct net *net,
continue;
if (rt->fib6_flags & RTF_REJECT)
break;
- if (fl6->flowi6_oif != rt->fib6_nh.fib_nh_dev->ifindex)
- continue;
if (ip6_redirect_nh_match(rt, &rt->fib6_nh, fl6,
&rdfl->gateway, &ret))
goto out;
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] ipv6: Remove flowi6_oif compare from __ip6_route_redirect
2019-04-12 17:31 [PATCH net-next] ipv6: Remove flowi6_oif compare from __ip6_route_redirect David Ahern
@ 2019-04-13 0:05 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-04-13 0:05 UTC (permalink / raw)
To: dsahern; +Cc: netdev, dsahern
From: David Ahern <dsahern@kernel.org>
Date: Fri, 12 Apr 2019 10:31:14 -0700
> From: David Ahern <dsahern@gmail.com>
>
> In the review of 0b34eb004347 ("ipv6: Refactor __ip6_route_redirect"),
> Martin noted that the flowi6_oif compare is moved to the new helper and
> should be removed from __ip6_route_redirect. Fix the oversight.
>
> Fixes: 0b34eb004347 ("ipv6: Refactor __ip6_route_redirect")
> Reported-by: Martin Lau <kafai@fb.com>
> Signed-off-by: David Ahern <dsahern@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-04-13 0:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-12 17:31 [PATCH net-next] ipv6: Remove flowi6_oif compare from __ip6_route_redirect David Ahern
2019-04-13 0:05 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).