From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43B7DC10F0E for ; Fri, 12 Apr 2019 17:30:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0F7CF2171F for ; Fri, 12 Apr 2019 17:30:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555090251; bh=y02HahEOafo4CgqYoArwD9r3BV0wMjtRBRnbjfwWeLM=; h=From:To:Cc:Subject:Date:List-ID:From; b=NZxag1qGiBlwpkPyAGCFVDwRCneRWTA/RHDvEsPT3DTv2dMGlfFZwTVSrEv47tfxT wgS9Ijcf8p/Ph1OSEPsH7Q0coqxQcjAXhQLOE+XIZG4Pdx75SxKEVkLgs/k6fUJ9iQ 2W5RXn9RGtST+oJWkWTx5GKS6fraX3y2jEezCGZ0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726886AbfDLRau (ORCPT ); Fri, 12 Apr 2019 13:30:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:40862 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726796AbfDLRat (ORCPT ); Fri, 12 Apr 2019 13:30:49 -0400 Received: from kenny.it.cumulusnetworks.com. (fw.cumulusnetworks.com [216.129.126.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 072BA2171F; Fri, 12 Apr 2019 17:30:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555090249; bh=y02HahEOafo4CgqYoArwD9r3BV0wMjtRBRnbjfwWeLM=; h=From:To:Cc:Subject:Date:From; b=I3G7D0xZYt/2rsmLLbhhIhJ4G84ID1EjYFblQUFlDPcSHp57p+WUUsq+WdeYvojQk gxagHbCbSfaYNjchiSVtWC43R5yZRff4QhBAbldO3VK698IYyGJAQRNMQkMKjmv3Y9 Z2gojuh1fhqMKqbHztFT7xiIGSXl2nHU+m36iZJA= From: David Ahern To: davem@davemloft.net Cc: netdev@vger.kernel.org, David Ahern Subject: [PATCH net-next] ipv6: Remove flowi6_oif compare from __ip6_route_redirect Date: Fri, 12 Apr 2019 10:31:14 -0700 Message-Id: <20190412173114.1182-1-dsahern@kernel.org> X-Mailer: git-send-email 2.11.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: David Ahern In the review of 0b34eb004347 ("ipv6: Refactor __ip6_route_redirect"), Martin noted that the flowi6_oif compare is moved to the new helper and should be removed from __ip6_route_redirect. Fix the oversight. Fixes: 0b34eb004347 ("ipv6: Refactor __ip6_route_redirect") Reported-by: Martin Lau Signed-off-by: David Ahern --- net/ipv6/route.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/ipv6/route.c b/net/ipv6/route.c index d555edaaff13..a77c004d67fb 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -2471,8 +2471,6 @@ static struct rt6_info *__ip6_route_redirect(struct net *net, continue; if (rt->fib6_flags & RTF_REJECT) break; - if (fl6->flowi6_oif != rt->fib6_nh.fib_nh_dev->ifindex) - continue; if (ip6_redirect_nh_match(rt, &rt->fib6_nh, fl6, &rdfl->gateway, &ret)) goto out; -- 2.11.0