From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33509C10F0E for ; Fri, 12 Apr 2019 22:47:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E8BEF20818 for ; Fri, 12 Apr 2019 22:47:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="pmLB+YYC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726862AbfDLWrq (ORCPT ); Fri, 12 Apr 2019 18:47:46 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:59813 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726477AbfDLWrq (ORCPT ); Fri, 12 Apr 2019 18:47:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=4kXStC1/UaczOsDGKWzaTeUwM8QKA/+z8X0T5IHyOuE=; b=pmLB+YYClKT8C2pMJzoBaPDgAJ quW+npiLF5ZWRRlCiOoeNoaL6TleQ8Zk8qEPb4hMjiWTJPC4naUzrrgxpvJoEonWE96Sw+SY3ssxD A9MGLyTW0FJ2O0V6195gCSvvTUUrse1/6rb3Rufgr4+I2qMBCwQqEF88/iKuLhRsJymE=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hF4xN-0000ps-W4; Sat, 13 Apr 2019 00:47:38 +0200 Date: Sat, 13 Apr 2019 00:47:37 +0200 From: Andrew Lunn To: Heiner Kallweit Cc: Florian Fainelli , David Miller , Ray Jui , Scott Branden , Richard Cochran , Kevin Hilman , Heiko Stuebner , bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v2 net-next] net: phy: switch drivers to use dynamic feature detection Message-ID: <20190412224737.GA1004@lunn.ch> References: <3179601a-c58d-4df3-5d90-eb3598d2827b@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3179601a-c58d-4df3-5d90-eb3598d2827b@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Apr 12, 2019 at 08:47:03PM +0200, Heiner Kallweit wrote: > Recently genphy_read_abilities() has been added that dynamically detects > clause 22 PHY abilities. I *think* this detection should work with all > supported PHY's, at least for the ones with basic features sets, i.e. > PHY_BASIC_FEATURES and PHY_GBIT_FEATURES. So let's remove setting these > features explicitly and rely on phylib feature detection. > > I don't have access to most of these PHY's, therefore I'd appreciate > regression testing. Hi Heiner I tested v1 on the following PHYs: 88E1510, 88E1540, 88E6390, KSZ8041, 88E1545 No obvious regressions. Tested-by: Andrew Lunn Andrew