From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=ka9z=SP=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT
	autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 2C2C9C10F11
	for <netdev@archiver.kernel.org>; Sat, 13 Apr 2019 17:08:57 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id E82012082E
	for <netdev@archiver.kernel.org>; Sat, 13 Apr 2019 17:08:56 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="mWOhGOYG"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727113AbfDMRIO (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Sat, 13 Apr 2019 13:08:14 -0400
Received: from vps0.lunn.ch ([185.16.172.187]:60406 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726973AbfDMRIO (ORCPT <rfc822;netdev@vger.kernel.org>);
        Sat, 13 Apr 2019 13:08:14 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch;
        s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:
        Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID:
        Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
        :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
        List-Post:List-Owner:List-Archive;
        bh=UsKoY4nax9ymivvayDEmbtkT3+cqLWpxpKe/j8jv66A=; b=mWOhGOYG4wgfTcYvudohwfxoa0
        kCCRrAXe4UPMRKIhLZtqmQKnWOOqP7fYU0hMikD+C0Bx1MVnyf3CROm2v9SAHOtemtMJXjdIpCI03
        VlpQCfQ27sG2+MMK8CG+lxfCH3optMAb+liKJpiKhsqEi7y8AvLyCi7OVeQcURZIfxU0=;
Received: from andrew by vps0.lunn.ch with local (Exim 4.89)
        (envelope-from <andrew@lunn.ch>)
        id 1hFM7n-0005oB-3B; Sat, 13 Apr 2019 19:07:31 +0200
Date:   Sat, 13 Apr 2019 19:07:30 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     Heiner Kallweit <hkallweit1@gmail.com>
Cc:     Florian Fainelli <f.fainelli@gmail.com>,
        David Miller <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 0/2] net: phy: shrink PHY settings array and add
 200Gbps support
Message-ID: <20190413170730.GL17901@lunn.ch>
References: <2ef3d8a7-3cff-cea6-646a-4b2ed0834398@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2ef3d8a7-3cff-cea6-646a-4b2ed0834398@gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

On Sat, Apr 13, 2019 at 06:51:16PM +0200, Heiner Kallweit wrote:
> The definition of array settings[] is quite lengthy meanwhile. Add a
> macro to shrink the definition.
> 
> When doing this I saw that the new 200Gbps modes aren't supported
> in phylib yet. So add this. I think we need to document somewhere
> which places in phylib need to be touched if a new speed / mode is
> added.

Yes, maybe something like

BUILD_BUG_ON(__ETHTOOL_LINK_MODE_MASK_NBITS != 67);

in drivers/net/phy/phy-core.c with a comment explaining what should be
done?

	Andrew