From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86A92C10F11 for ; Sat, 13 Apr 2019 17:15:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4FB4A2147A for ; Sat, 13 Apr 2019 17:15:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="0e0WlJna" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727250AbfDMRPD (ORCPT ); Sat, 13 Apr 2019 13:15:03 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:60410 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726973AbfDMRPD (ORCPT ); Sat, 13 Apr 2019 13:15:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=myGTH/cZfhKFoqWqTdPEs6ffHsgD2P7VBU93OuZ7BZU=; b=0e0WlJnaemtPe8RitxEPdxo2vA cfL0Fq0y7A/CWKJS3AOy/1IaE7nuPdgD4mHgoZxz84UwgFxwB/2l+otVn8lVXNIhAsekg6+nzi0gJ bM7In4jOd7ed55OyuZ+dbfSvWJQNdBrGLZ1TCvSu/SeMqrQOrXS7iZgZm1YVQKdZSteg=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hFMEO-0005ry-1i; Sat, 13 Apr 2019 19:14:20 +0200 Date: Sat, 13 Apr 2019 19:14:20 +0200 From: Andrew Lunn To: Heiner Kallweit Cc: Florian Fainelli , David Miller , "netdev@vger.kernel.org" Subject: Re: [PATCH net-next 1/2] net: phy: shrink PHY settings array Message-ID: <20190413171420.GM17901@lunn.ch> References: <2ef3d8a7-3cff-cea6-646a-4b2ed0834398@gmail.com> <7b5994b6-bcbb-9c6c-fd08-7240cf9b903f@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7b5994b6-bcbb-9c6c-fd08-7240cf9b903f@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > + PHY_SETTING( 100000, FULL, 100000baseCR4_Full ), > + PHY_SETTING( 100000, FULL, 100000baseKR4_Full ), > + PHY_SETTING( 100000, FULL, 100000baseLR4_ER4_Full ), > + PHY_SETTING( 100000, FULL, 100000baseSR4_Full ), > + PHY_SETTING( 56000, FULL, 56000baseCR4_Full ), > + PHY_SETTING( 56000, FULL, 56000baseKR4_Full ), > + PHY_SETTING( 56000, FULL, 56000baseLR4_Full ), > + PHY_SETTING( 56000, FULL, 56000baseSR4_Full ), > + PHY_SETTING( 50000, FULL, 50000baseCR2_Full ), > + PHY_SETTING( 50000, FULL, 50000baseKR2_Full ), > + PHY_SETTING( 50000, FULL, 50000baseSR2_Full ), > + PHY_SETTING( 40000, FULL, 40000baseCR4_Full ), > + PHY_SETTING( 40000, FULL, 40000baseKR4_Full ), > + PHY_SETTING( 40000, FULL, 40000baseLR4_Full ), > + PHY_SETTING( 40000, FULL, 40000baseSR4_Full ), > + PHY_SETTING( 20000, FULL, 20000baseKR2_Full ), > + PHY_SETTING( 20000, FULL, 20000baseMLD2_Full ), > + PHY_SETTING( 10000, FULL, 10000baseCR_Full ), > + PHY_SETTING( 10000, FULL, 10000baseER_Full ), > + PHY_SETTING( 10000, FULL, 10000baseKR_Full ), > + PHY_SETTING( 10000, FULL, 10000baseKX4_Full ), > + PHY_SETTING( 10000, FULL, 10000baseLR_Full ), > + PHY_SETTING( 10000, FULL, 10000baseLRM_Full ), > + PHY_SETTING( 10000, FULL, 10000baseR_FEC ), > + PHY_SETTING( 10000, FULL, 10000baseSR_Full ), > + PHY_SETTING( 10000, FULL, 10000baseT_Full ), > + PHY_SETTING( 2500, FULL, 2500baseT_Full ), > + PHY_SETTING( 2500, FULL, 2500baseX_Full ), > + PHY_SETTING( 1000, FULL, 1000baseKX_Full ), > + PHY_SETTING( 1000, FULL, 1000baseT_Full ), > + PHY_SETTING( 1000, HALF, 1000baseT_Half ), > + PHY_SETTING( 1000, FULL, 1000baseX_Full ), > + PHY_SETTING( 100, FULL, 100baseT_Full ), > + PHY_SETTING( 100, HALF, 100baseT_Half ), > + PHY_SETTING( 10, FULL, 10baseT_Full ), > + PHY_SETTING( 10, HALF, 10baseT_Half ), I like the spaces here for the speed. I know i've missed counted the number of 0 and put entries in the wrong place. Maybe 2500base* and later could be indented by one more space, so that 'base' is always in the same column? Andrew