From: Andrew Lunn <andrew@lunn.ch>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Igor Russkikh <Igor.Russkikh@aquantia.com>,
"David S . Miller" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Nikita Danilov <Nikita.Danilov@aquantia.com>,
Dmitry Bogdanov <Dmitry.Bogdanov@aquantia.com>
Subject: Re: [PATCH netnext 04/16] net: aquantia: link interrupt handling functions
Date: Sat, 13 Apr 2019 20:10:23 +0200 [thread overview]
Message-ID: <20190413181023.GQ17901@lunn.ch> (raw)
In-Reply-To: <d63c61c1-77d6-185c-c208-0225e4337185@gmail.com>
> If you just schedule a task from the hard irq handler, why not using
> a threaded interrupt?
Yes, i was just about to say that.
> And a further question because I worked on the Aquantia PHY driver:
> I assume the integrated PHY's are identical or at least very similar
> to the external ones like AQR107. Did you ever consider to switch
> the PHY handling part of this driver to phylib? This may help to
> reduce complexity and code size of the driver.
Hi Heiner
I think this was discussed at the time the driver was first
submitted. Or it could of been the USB version. The first version did
actually allow access to PHY registers, and the MAC driver did poke
some of the registers.
My guess is, other operating systems don't have a suitable PHY
driver. So they pushed it all into firmware. As a result, they now
possibly have an inferior experience on Linux than if they used the
new PHY driver.
Andrew
next prev parent reply other threads:[~2019-04-13 18:16 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-13 12:31 [PATCH netnext 00/16] net: atlantic: Aquantia driver updates 2019-04 Igor Russkikh
2019-04-13 12:31 ` [PATCH netnext 01/16] net: aquantia: add infrastructure to readout chip temperature Igor Russkikh
2019-04-13 17:51 ` Andrew Lunn
2019-04-13 18:14 ` Andrew Lunn
2019-04-13 18:16 ` Igor Russkikh
2019-04-13 12:31 ` [PATCH netnext 02/16] net: aquantia: implement hwmon api for " Igor Russkikh
2019-04-13 17:59 ` Andrew Lunn
2019-04-13 18:27 ` Igor Russkikh
2019-04-13 18:42 ` Andrew Lunn
2019-04-22 13:51 ` Igor Russkikh
2019-04-13 12:31 ` [PATCH netnext 03/16] net: aquantia: add link interrupt fields Igor Russkikh
2019-04-13 12:31 ` [PATCH netnext 04/16] net: aquantia: link interrupt handling functions Igor Russkikh
2019-04-13 13:37 ` Heiner Kallweit
2019-04-13 18:10 ` Andrew Lunn [this message]
2019-04-13 18:22 ` Igor Russkikh
2019-04-13 18:26 ` Heiner Kallweit
2019-04-13 12:31 ` [PATCH netnext 05/16] net: aquantia: create global service workqueue Igor Russkikh
2019-04-13 12:31 ` [PATCH netnext 06/16] net: aquantia: link status irq handling Igor Russkikh
2019-04-13 12:31 ` [PATCH netnext 07/16] net: aquantia: improve ifup link detection Igor Russkikh
2019-04-13 12:32 ` [PATCH netnext 08/16] net: aquantia: use macros for better visibility Igor Russkikh
2019-04-13 12:32 ` [PATCH netnext 09/16] net: aquantia: user correct MSI irq type Igor Russkikh
2019-04-13 12:32 ` [PATCH netnext 10/16] net: aquantia: introduce fwreq mutex Igor Russkikh
2019-04-13 12:32 ` [PATCH netnext 11/16] net: aquantia: extract timer cb into work job Igor Russkikh
2019-04-13 12:32 ` [PATCH netnext 12/16] net: aquantia: wrap fw ops by mutex Igor Russkikh
2019-04-13 18:24 ` Andrew Lunn
2019-04-13 12:32 ` [PATCH netnext 13/16] net: aquantia: fetch up to date statistics on ethtool request Igor Russkikh
2019-04-13 12:32 ` [PATCH netnext 14/16] net: aquantia: get total counters from DMA block Igor Russkikh
2019-04-13 12:32 ` [PATCH netnext 15/16] net: aquantia: fixups on 64bit dma counters Igor Russkikh
2019-04-13 12:32 ` [PATCH netnext 16/16] net: aquantia: remove outdated device ids Igor Russkikh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190413181023.GQ17901@lunn.ch \
--to=andrew@lunn.ch \
--cc=Dmitry.Bogdanov@aquantia.com \
--cc=Igor.Russkikh@aquantia.com \
--cc=Nikita.Danilov@aquantia.com \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).