From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1DB6C10F11 for ; Sat, 13 Apr 2019 18:16:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 61CFA2084E for ; Sat, 13 Apr 2019 18:16:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="akOFr3No" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726998AbfDMSKa (ORCPT ); Sat, 13 Apr 2019 14:10:30 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:60471 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726897AbfDMSK3 (ORCPT ); Sat, 13 Apr 2019 14:10:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=s5Om+4Vb+8JVOwJx1gUDjXO5kdjupCzxU9rgDlZD0dk=; b=akOFr3NoBPZ8LEW+x8P4sx0AMz 3QnRCGP4DGlFwnrzKW69EytAGxzLiKQWtPUkDXStVSZWfHyHBbq5vZzbuEXo/4CNTkbttpN2zflfG ZO/5yOFVOBsMypihCd7dal3iecO0c3wl9sehGXJt/im+O9R7d+/atDWbFVL+ayDdnJIc=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hFN6d-0006Nt-Af; Sat, 13 Apr 2019 20:10:23 +0200 Date: Sat, 13 Apr 2019 20:10:23 +0200 From: Andrew Lunn To: Heiner Kallweit Cc: Igor Russkikh , "David S . Miller" , "netdev@vger.kernel.org" , Nikita Danilov , Dmitry Bogdanov Subject: Re: [PATCH netnext 04/16] net: aquantia: link interrupt handling functions Message-ID: <20190413181023.GQ17901@lunn.ch> References: <063cc941fd2fac3d999b0020c1dce7bcc96e93c9.1555158087.git.igor.russkikh@aquantia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > If you just schedule a task from the hard irq handler, why not using > a threaded interrupt? Yes, i was just about to say that. > And a further question because I worked on the Aquantia PHY driver: > I assume the integrated PHY's are identical or at least very similar > to the external ones like AQR107. Did you ever consider to switch > the PHY handling part of this driver to phylib? This may help to > reduce complexity and code size of the driver. Hi Heiner I think this was discussed at the time the driver was first submitted. Or it could of been the USB version. The first version did actually allow access to PHY registers, and the MAC driver did poke some of the registers. My guess is, other operating systems don't have a suitable PHY driver. So they pushed it all into firmware. As a result, they now possibly have an inferior experience on Linux than if they used the new PHY driver. Andrew