From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=ka9z=SP=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT
	autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id CAED8C10F14
	for <netdev@archiver.kernel.org>; Sat, 13 Apr 2019 18:16:37 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 9301A21721
	for <netdev@archiver.kernel.org>; Sat, 13 Apr 2019 18:16:37 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="qkFcLBd4"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727006AbfDMSOJ (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Sat, 13 Apr 2019 14:14:09 -0400
Received: from vps0.lunn.ch ([185.16.172.187]:60475 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726897AbfDMSOI (ORCPT <rfc822;netdev@vger.kernel.org>);
        Sat, 13 Apr 2019 14:14:08 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch;
        s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:
        Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID:
        Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
        :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
        List-Post:List-Owner:List-Archive;
        bh=keiAzkvYl5NDE6+nfg1ed0sKa9lrRWS08IYntgz1lQw=; b=qkFcLBd4kafdOcagHfxYtp31fM
        iTtSwSvKp50AXbp3fqDrTdNLSFDjoQjuEE8XjQc3QqKa0e2WmOV8+x8l01otcgnXxJKpfpMVkE0gh
        PB8rbJ3osIzsA2lJfDNfHXLr7pyHSVIp5lYMcypD12BOH+LIaTQxlse/2IbDjmms5Di4=;
Received: from andrew by vps0.lunn.ch with local (Exim 4.89)
        (envelope-from <andrew@lunn.ch>)
        id 1hFNAE-0006QC-5o; Sat, 13 Apr 2019 20:14:06 +0200
Date:   Sat, 13 Apr 2019 20:14:06 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     Igor Russkikh <Igor.Russkikh@aquantia.com>
Cc:     "David S . Miller" <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Nikita Danilov <Nikita.Danilov@aquantia.com>,
        Dmitry Bogdanov <Dmitry.Bogdanov@aquantia.com>,
        Yana Esina <yana.esina@aquantia.com>
Subject: Re: [PATCH netnext 01/16] net: aquantia: add infrastructure to
 readout chip temperature
Message-ID: <20190413181406.GR17901@lunn.ch>
References: <cover.1555158087.git.igor.russkikh@aquantia.com>
 <fc0b54a8fcaeb78962a9da2a8107853bb3b4a36b.1555158087.git.igor.russkikh@aquantia.com>
 <20190413175105.GO17901@lunn.ch>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190413175105.GO17901@lunn.ch>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

On Sat, Apr 13, 2019 at 07:51:05PM +0200, Andrew Lunn wrote:
> On Sat, Apr 13, 2019 at 12:31:43PM +0000, Igor Russkikh wrote:
> > From: Yana Esina <yana.esina@aquantia.com>
> > 
> > Ability to read the chip temperature from memory
> > via hwmon interface
> 
> > +	/* Convert PHY temperature from 1/256 degree Celsius
> > +	 * to 1/1000 degree Celsius.
> > +	 */
> > +	*temp = temp_res  * 1000 / 256;
> > +
> > +	return 0;
> > +}

Hi Igor, Yana

To bring this up to par with the aquantia PHY driver, you might want
to also export the high/low warn and fail temperatures.

   Andrew