From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF1F6C282DA for ; Sat, 13 Apr 2019 20:21:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BD1B42087F for ; Sat, 13 Apr 2019 20:21:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="TCIFFbPv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727103AbfDMUSb (ORCPT ); Sat, 13 Apr 2019 16:18:31 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:60540 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727044AbfDMUSb (ORCPT ); Sat, 13 Apr 2019 16:18:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=IC5+k+CdKgkZ9cZe0dX5Ta7ZDjrneMr/aS8Ll5JG8fY=; b=TCIFFbPvNVvAv/TQKlrrpIAKpn w/g10yU0p9GtlfQQkrGOxqgMrVQyqD/UndWg8hoTQsTEx+to9MIKIpGgFmz9exp9J9iZ9w6hUnsWY zO6583hvt6h5qriNFNVNq6hXyYIid65528SZ356xajC2kq7bQVT5EM35sY1K/tfZswUg=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hFP6b-0007O5-Cz; Sat, 13 Apr 2019 22:18:29 +0200 Date: Sat, 13 Apr 2019 22:18:29 +0200 From: Andrew Lunn To: Heiner Kallweit Cc: Florian Fainelli , David Miller , "netdev@vger.kernel.org" Subject: Re: [PATCH v2 net-next 3/3] phy: warn if phylib and ethtool PHY mode definitions are out of sync Message-ID: <20190413201829.GC28091@lunn.ch> References: <35d549cb-7c40-b942-b002-305710fde6f0@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <35d549cb-7c40-b942-b002-305710fde6f0@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, Apr 13, 2019 at 08:53:43PM +0200, Heiner Kallweit wrote: > If new PHY modes are added people may miss to update all relevant places > in the kernel. Therefore add a build bug check for new modes in enum > ethtool_link_mode_bit_indices that haven't been added to phylib yet. > > Suggested-by: Andrew Lunn > Signed-off-by: Heiner Kallweit Reviewed-by: Andrew Lunn Andrew