From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C46DBC10F13 for ; Sun, 14 Apr 2019 20:27:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9242220870 for ; Sun, 14 Apr 2019 20:27:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726308AbfDNU16 (ORCPT ); Sun, 14 Apr 2019 16:27:58 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:43560 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725797AbfDNU16 (ORCPT ); Sun, 14 Apr 2019 16:27:58 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 7A5B914C6B7BA; Sun, 14 Apr 2019 13:27:57 -0700 (PDT) Date: Sun, 14 Apr 2019 13:27:56 -0700 (PDT) Message-Id: <20190414.132756.1745377576240759524.davem@davemloft.net> To: jiri@resnulli.us Cc: netdev@vger.kernel.org, mlxsw@mellanox.com, jakub.kicinski@netronome.com Subject: Re: [patch net-next rfc 04/15] netdevsim: put netdevsim bus code into separate file From: David Miller In-Reply-To: <20190413162112.8203-5-jiri@resnulli.us> References: <20190413162112.8203-1-jiri@resnulli.us> <20190413162112.8203-5-jiri@resnulli.us> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 14 Apr 2019 13:27:57 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jiri Pirko Date: Sat, 13 Apr 2019 18:21:01 +0200 > @@ -3,7 +3,7 @@ > obj-$(CONFIG_NETDEVSIM) += netdevsim.o > > netdevsim-objs := \ > - netdev.o dev.o fib.o sdev.o \ > + netdev.o dev.o fib.o sdev.o bus.o \ > I know this is unrelated to what you are trying to do, but could you please also get rid of that trailing backslash? Thank you.