From: David Miller <davem@davemloft.net>
To: sd@queasysnail.net
Cc: netdev@vger.kernel.org, j.vosburgh@gmail.com, vfalico@gmail.com,
andy@greyhouse.net, jarod@redhat.com
Subject: Re: [PATCH net] bonding: fix event handling for stacked bonds
Date: Mon, 15 Apr 2019 13:23:00 -0700 (PDT) [thread overview]
Message-ID: <20190415.132300.1393304596588046569.davem@davemloft.net> (raw)
In-Reply-To: <9e7fda25884e8e68b1932a48de58189a08ef906f.1555073754.git.sd@queasysnail.net>
From: Sabrina Dubroca <sd@queasysnail.net>
Date: Fri, 12 Apr 2019 15:04:10 +0200
> When a bond is enslaved to another bond, bond_netdev_event() only
> handles the event as if the bond is a master, and skips treating the
> bond as a slave.
>
> This leads to a refcount leak on the slave, since we don't remove the
> adjacency to its master and the master holds a reference on the slave.
>
> Reproducer:
> ip link add bondL type bond
> ip link add bondU type bond
> ip link set bondL master bondU
> ip link del bondL
>
> No "Fixes:" tag, this code is older than git history.
>
> Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
Applied and queued up for -stable, thanks Sabrina.
prev parent reply other threads:[~2019-04-15 20:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-12 13:04 [PATCH net] bonding: fix event handling for stacked bonds Sabrina Dubroca
2019-04-12 13:57 ` Jiri Pirko
2019-04-12 14:12 ` Sabrina Dubroca
2019-04-15 20:23 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190415.132300.1393304596588046569.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andy@greyhouse.net \
--cc=j.vosburgh@gmail.com \
--cc=jarod@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sd@queasysnail.net \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox