From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3DEAC10F0E for ; Mon, 15 Apr 2019 05:41:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6EE7C20833 for ; Mon, 15 Apr 2019 05:41:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="hBAXeAhJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725875AbfDOFlI (ORCPT ); Mon, 15 Apr 2019 01:41:08 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:52314 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725779AbfDOFlH (ORCPT ); Mon, 15 Apr 2019 01:41:07 -0400 Received: by mail-wm1-f67.google.com with SMTP id a184so18895158wma.2 for ; Sun, 14 Apr 2019 22:41:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=08qM3nbvyyHm4bSs6UV2Zj7gTMz0OJgZ8mM4t61dADQ=; b=hBAXeAhJeFQFLdmtKVnWR+0kewIOt2c8uAmVyBQVGYjAfhubNvb+Yu61SOjaoP6miQ pRKs6hd7ekdBgHTlj5Ydz8YoGUjjmprs0KMJkdX8QdAgfwKd73nR7xUgp1pSetPomvfm T1iH5FsfX2WWRMO5+HnpLDuXcoKR5A23xQbl0acgcwv0B3qJwGa7/aoWpofQdUkKUxzU ar+iAXBTYQjKXfg2ksZkEMXTbXWCQk8llSSpknPxmh6c1XsCxLOVVcSg1DmIWefWvdiD GAlReFi2yYLJOTV4VDJuOH/ij3QosrM5jRok2fx6hXv01dTKgkXxWdtf5IxO9zc16GWc kpUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=08qM3nbvyyHm4bSs6UV2Zj7gTMz0OJgZ8mM4t61dADQ=; b=kBIEUiNoV59xthtdaVdS1X+QSzb5OqMD40mh0UmNQ5GQZrVhciNgJT/O4+8/KWJkwI msb0KZQ+XyWYFlgJe+lxksLt9052SLD9rEpoe4lPLXnHDbyb6Hx5SmFzr0SXooDQHYSW T7D53vWhVQBhDjFCy+/2x5FHgTrYE24z8/5R1Y8k5BEBGNi+CetnA95gJAKRHjfHVuNA HqICKrgr288YDpvXlFdEphzg+rzhA32irmdXKMQ4cvC//k3ABx7El0liYO9XWe9np7ey qKabU9HbXlWw5CW1aPkmZSblHhSfaXLJe4Ccwh+thMT0JHst5SPOayIvVIPUQszgRb8w vYTQ== X-Gm-Message-State: APjAAAXOS20fJPMhsYw4NbX4KaNtaepnrn099WNLKOj6Kw6VkOEgpqHF 7kraCVa8XOjnRjWsAT7DnO31dw== X-Google-Smtp-Source: APXvYqzN4386QKG+AH5WDSsusxChI7369tsNZyn6xp1CxuRHhz4NIq79htP/BmUZFpq/xQct1iNPug== X-Received: by 2002:a1c:1c5:: with SMTP id 188mr20972905wmb.52.1555306866187; Sun, 14 Apr 2019 22:41:06 -0700 (PDT) Received: from localhost (jirka.pirko.cz. [84.16.102.26]) by smtp.gmail.com with ESMTPSA id f128sm16613868wme.28.2019.04.14.22.41.05 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 14 Apr 2019 22:41:05 -0700 (PDT) Date: Mon, 15 Apr 2019 07:41:04 +0200 From: Jiri Pirko To: David Ahern Cc: netdev@vger.kernel.org, davem@davemloft.net, mlxsw@mellanox.com, jakub.kicinski@netronome.com Subject: Re: [patch net-next rfc 02/15] netdevsim: create devlink instance per netdevsim instance Message-ID: <20190415054104.GD24144@nanopsycho.orion> References: <20190413162112.8203-1-jiri@resnulli.us> <20190413162112.8203-3-jiri@resnulli.us> <519cfd86-dcc8-9dc4-1929-71ea1084689b@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <519cfd86-dcc8-9dc4-1929-71ea1084689b@gmail.com> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Mon, Apr 15, 2019 at 04:24:24AM CEST, dsahern@gmail.com wrote: >On 4/13/19 10:20 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Currently there is one devlink instance created per network namespace. >> That is quite odd considering the fact that devlink instance should >> represent an ASIC. The following patches are going to move the devlink >> instance even more down to a bus device, but until then, have one >> devlink instance per netdevsim instance. Struct nsim_devlink is >> introduced to hold fib setting. >> >> Signed-off-by: Jiri Pirko >> --- >> drivers/net/netdevsim/devlink.c | 179 +++++++++++------------------- >> drivers/net/netdevsim/fib.c | 103 +++++++---------- >> drivers/net/netdevsim/netdev.c | 27 ++--- >> drivers/net/netdevsim/netdevsim.h | 18 +-- >> 4 files changed, 125 insertions(+), 202 deletions(-) > >you are making a lot of changes to how fib events are handled and not >explaining what you are doing. They are handled in the exact same way. This is just about devlink instance. Will add that to description.