From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F28CFC10F0E for ; Mon, 15 Apr 2019 15:39:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B40A92147C for ; Mon, 15 Apr 2019 15:39:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="r3yM0L7p" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727328AbfDOPje (ORCPT ); Mon, 15 Apr 2019 11:39:34 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:40491 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726034AbfDOPje (ORCPT ); Mon, 15 Apr 2019 11:39:34 -0400 Received: by mail-wm1-f68.google.com with SMTP id z24so21205710wmi.5 for ; Mon, 15 Apr 2019 08:39:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=rN0Sjpddils2Nqsiq2ELXdLvWjkTxyoRLO+wNk9I0ws=; b=r3yM0L7pmmmfBrcyaBCJv++38iZomtxEYUyx2DQ2/XfzDZbapfG/mxfjVx1TOKPlWB ZbViDUeziI02uFxg6i7x55LKz+TUfXpgbQfwUU+jgMzzYzXmoWq4kaA3QwIYSzO+y+oz WCx1TBnSAhIiV4D8hMruZldfx6B7/rG3pDQ4oIK5/SML/JwvjZPLLWDTna5vf8NmCTEf 4201kXNeUKKzxxjjTUjwUgnlLhd8dGv6pRLpyFzj0D4g8BEEpysZiX4aaAnNuIjq3Q80 lBk5QqO7CcNkmX9eY3w5O1povBxhkH0cGOiY1xYOQpWHXTbO93/9R5zw3l4ouuKwIa/S VDGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=rN0Sjpddils2Nqsiq2ELXdLvWjkTxyoRLO+wNk9I0ws=; b=My6jZiZPsH+KEkGGaKm+v4SWbD4ADytAY4M1yQlvksZEv4c3ik2iIiu4yrLv8ulRei 4cWRiUeWorfuZsfsHUWJ56gZ7gmseepCaBZSdD7LxbBSmIJP7JPHJN5R8imq7sN84Qsw 6pKAhZsQQaZwAwyQmomI4NtblU4/Ai2Gu2JloYnYlRiuHZU8D490Iy9oKRV+MKvfnBsS 7pu7h+iuxADEK30z1aEp2ZqZxF/dDNiAHqPv6z5iS/coCets7coy2myf3zycjFDsgyUh iMC8ae8UVwSxQSQJho1XjnmK/JCU0CEZT24zRkU2ZZ5WAiJHFu1BE//Z5ARi25TLhK0Z bB+A== X-Gm-Message-State: APjAAAVCLdioXKU292BpZWuE+QTCydEuYB+HLIAZJbN2e5y7/Fd3H1QS 1KFoFJjQNhgTTPxdA6c/JXtsgQ== X-Google-Smtp-Source: APXvYqzx/sqEvbCAYJ7mhEKLUKCOIIMG0Sx/cPG7/NFg9yL/z26lbf3qzO7Bo2sTp1N8f7fQIY+IxQ== X-Received: by 2002:a7b:c1cf:: with SMTP id a15mr21830250wmj.44.1555342772513; Mon, 15 Apr 2019 08:39:32 -0700 (PDT) Received: from localhost (jirka.pirko.cz. [84.16.102.26]) by smtp.gmail.com with ESMTPSA id d6sm12813096wrp.9.2019.04.15.08.39.31 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 15 Apr 2019 08:39:32 -0700 (PDT) Date: Mon, 15 Apr 2019 17:39:31 +0200 From: Jiri Pirko To: David Ahern Cc: netdev@vger.kernel.org, davem@davemloft.net, mlxsw@mellanox.com, jakub.kicinski@netronome.com Subject: Re: [patch net-next rfc 02/15] netdevsim: create devlink instance per netdevsim instance Message-ID: <20190415153931.GA4918@nanopsycho.orion> References: <20190413162112.8203-1-jiri@resnulli.us> <20190413162112.8203-3-jiri@resnulli.us> <519cfd86-dcc8-9dc4-1929-71ea1084689b@gmail.com> <20190415054104.GD24144@nanopsycho.orion> <2e024c38-0368-1dae-4be5-07b34d596a58@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2e024c38-0368-1dae-4be5-07b34d596a58@gmail.com> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Mon, Apr 15, 2019 at 05:07:04PM CEST, dsahern@gmail.com wrote: >On 4/14/19 11:41 PM, Jiri Pirko wrote: >> Mon, Apr 15, 2019 at 04:24:24AM CEST, dsahern@gmail.com wrote: >>> On 4/13/19 10:20 AM, Jiri Pirko wrote: >>>> From: Jiri Pirko >>>> >>>> Currently there is one devlink instance created per network namespace. >>>> That is quite odd considering the fact that devlink instance should >>>> represent an ASIC. The following patches are going to move the devlink >>>> instance even more down to a bus device, but until then, have one >>>> devlink instance per netdevsim instance. Struct nsim_devlink is >>>> introduced to hold fib setting. >>>> >>>> Signed-off-by: Jiri Pirko >>>> --- >>>> drivers/net/netdevsim/devlink.c | 179 +++++++++++------------------- >>>> drivers/net/netdevsim/fib.c | 103 +++++++---------- >>>> drivers/net/netdevsim/netdev.c | 27 ++--- >>>> drivers/net/netdevsim/netdevsim.h | 18 +-- >>>> 4 files changed, 125 insertions(+), 202 deletions(-) >>> >>> you are making a lot of changes to how fib events are handled and not >>> explaining what you are doing. >> >> They are handled in the exact same way. This is just about devlink >> instance. Will add that to description. >> > > >Data is currently stored as a net_generic. You are changing that. The >changelog should state that. Added that into description. Thanks.