From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=lHVB=SR=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT
	autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id D13E0C10F0E
	for <netdev@archiver.kernel.org>; Mon, 15 Apr 2019 17:01:09 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id A0AC02183F
	for <netdev@archiver.kernel.org>; Mon, 15 Apr 2019 17:01:09 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="SS6skM5B"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727954AbfDORBI (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Mon, 15 Apr 2019 13:01:08 -0400
Received: from vps0.lunn.ch ([185.16.172.187]:33746 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1727858AbfDORBH (ORCPT <rfc822;netdev@vger.kernel.org>);
        Mon, 15 Apr 2019 13:01:07 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch;
        s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:
        Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID:
        Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
        :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
        List-Post:List-Owner:List-Archive;
        bh=twec7dEGbHVp368qMDLertyzhaUBno0dZwHrCSmmfxs=; b=SS6skM5BR4lz1J2xJc/r7FoQD3
        pX7eWe7s3bgKnMpDKcURerzxobVkb2Z3KC963eSc3hTFufdyGL3gQzR61Qg7cDZiCh9SuHoKZHGdt
        WOCC2rrPSMI/HrDwhgOBo5nL1qIZxMQYqzlKV9hKao+5vJvAQLpCzIue/h/0svyQyqjw=;
Received: from andrew by vps0.lunn.ch with local (Exim 4.89)
        (envelope-from <andrew@lunn.ch>)
        id 1hG4ye-0005rd-Qu; Mon, 15 Apr 2019 19:01:04 +0200
Date:   Mon, 15 Apr 2019 19:01:04 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     David Bauer <mail@david-bauer.net>
Cc:     devicetree@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 2/3] net: phy: add support for reset-controller
Message-ID: <20190415170104.GC9343@lunn.ch>
References: <20190415123840.31407-1-mail@david-bauer.net>
 <20190415123840.31407-2-mail@david-bauer.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190415123840.31407-2-mail@david-bauer.net>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

On Mon, Apr 15, 2019 at 02:38:39PM +0200, David Bauer wrote:
> +static int mdiobus_register_reset(struct mdio_device *mdiodev)
> +{
> +	struct reset_control *reset = NULL;
> +
> +	if (mdiodev->dev.of_node)
> +		reset = devm_reset_control_get_exclusive(&mdiodev->dev,
> +							 "phy");
> +	if (PTR_ERR(reset) == -ENOENT ||
> +	    PTR_ERR(reset) == -ENOTSUPP)
> +		reset = NULL;
> +	else if (IS_ERR(reset))
> +		return PTR_ERR(reset);
> +
> +	mdiodev->reset_ctrl = reset;
> +
> +	/* Assert the reset signal */
> +	mdio_device_reset(mdiodev, 1);

Hi David

The mdiobus_register_gpiod() function also has a call to
mdio_device_reset(). So we end up resetting the GPIO twice.

It is probably better to pull this out of here, and
mdiobus_register_gpiod(), and do it once in mdiobus_register_device().

	  Andrew