* [PATCH 4.14] atm:idt77252: Fix a kernel address leakage in idt77252
@ 2019-04-16 6:57 Fuqian Huang
2019-04-16 8:56 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Fuqian Huang @ 2019-04-16 6:57 UTC (permalink / raw)
Cc: stable, gregkh, Fuqian Huang, Chas Williams, linux-atm-general,
netdev, linux-kernel
Outputting kernel addresses will reveal the locations of kernel code
and data. And there is no need to print the address of
function idt77252_init in idt77252_init.
This case is similar to CVE-2018-7273[1].
Just remove the print statement.
[1] https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2018-7273
Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
---
drivers/atm/idt77252.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/atm/idt77252.c b/drivers/atm/idt77252.c
index 47f3c4a..76e7736 100644
--- a/drivers/atm/idt77252.c
+++ b/drivers/atm/idt77252.c
@@ -3743,8 +3743,6 @@ static int __init idt77252_init(void)
{
struct sk_buff *skb;
- printk("%s: at %p\n", __func__, idt77252_init);
-
if (sizeof(skb->cb) < sizeof(struct atm_skb_data) +
sizeof(struct idt77252_skb_prv)) {
printk(KERN_ERR "%s: skb->cb is too small (%lu < %lu)\n",
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 4.14] atm:idt77252: Fix a kernel address leakage in idt77252
2019-04-16 6:57 [PATCH 4.14] atm:idt77252: Fix a kernel address leakage in idt77252 Fuqian Huang
@ 2019-04-16 8:56 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2019-04-16 8:56 UTC (permalink / raw)
To: Fuqian Huang
Cc: stable, Chas Williams, linux-atm-general, netdev, linux-kernel
On Tue, Apr 16, 2019 at 02:57:27PM +0800, Fuqian Huang wrote:
> Outputting kernel addresses will reveal the locations of kernel code
> and data. And there is no need to print the address of
> function idt77252_init in idt77252_init.
> This case is similar to CVE-2018-7273[1].
> Just remove the print statement.
>
> [1] https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2018-7273
>
> Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
> ---
> drivers/atm/idt77252.c | 2 --
> 1 file changed, 2 deletions(-)
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
</formletter>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-04-16 8:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-16 6:57 [PATCH 4.14] atm:idt77252: Fix a kernel address leakage in idt77252 Fuqian Huang
2019-04-16 8:56 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).