From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 453E2C10F13 for ; Tue, 16 Apr 2019 11:07:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0A4882073F for ; Tue, 16 Apr 2019 11:07:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555412865; bh=RTXbHp2st4kP+oOyLDO49HLZV+h5Pn0TtKDtkvUEAco=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=wAOi14YI23QYZgxaSLtNpbSmq6fNyeUTbrb2nmAQ8zQ44upMNfJcxQmkl4aT8ZtSc iOBQZn8eh2rQHArHy5XUP6z0Vd0pff5lczjyN/vrIfN3qsWnJLiiAJTsXOg3OOezp9 LSFXJ2RWzgFSWTXRx0Zy7P5NmE8XxxuYUA8cqPhw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728925AbfDPLHn (ORCPT ); Tue, 16 Apr 2019 07:07:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:41966 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726672AbfDPLHn (ORCPT ); Tue, 16 Apr 2019 07:07:43 -0400 Received: from localhost (unknown [193.47.165.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D696B2073F; Tue, 16 Apr 2019 11:07:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555412862; bh=RTXbHp2st4kP+oOyLDO49HLZV+h5Pn0TtKDtkvUEAco=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FkysFS0Pf7VE3x6Sl3dQSQLOkYqfPxo8JO1voCadypDuRgZqY5KLh2vz+EsABhp+/ TMcXyrq0mHGiOyNiiKQRT2ovhzjYImik22qT3Gx495PhelTv45uvsCtVam0RBPLXpH ItNr16MHsVZbLbLN1CH+i8dyOOUqtWES9DMqtfN4= From: Leon Romanovsky To: Doug Ledford , Jason Gunthorpe Cc: Leon Romanovsky , RDMA mailing list , Andrea Arcangeli , Feras Daoud , Haggai Eran , Jason Gunthorpe , Saeed Mahameed , linux-netdev Subject: [PATCH rdma-next 1/6] RDMA/mlx5: Do not allow the user to write to the clock page Date: Tue, 16 Apr 2019 14:07:25 +0300 Message-Id: <20190416110730.32230-2-leon@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190416110730.32230-1-leon@kernel.org> References: <20190416110730.32230-1-leon@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jason Gunthorpe The intent of this VMA was to be read-only from user space, but the VM_MAYWRITE masking was missed, so mprotect could make it writable. Cc: stable@vger.kernel.org Fixes: 5c99eaecb1fc ("IB/mlx5: Mmap the HCA's clock info to user-space") Signed-off-by: Jason Gunthorpe Reviewed-by: Haggai Eran Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c index 15676a149680..73b7f9636f82 100644 --- a/drivers/infiniband/hw/mlx5/main.c +++ b/drivers/infiniband/hw/mlx5/main.c @@ -2072,6 +2072,7 @@ static int mlx5_ib_mmap_clock_info_page(struct mlx5_ib_dev *dev, if (vma->vm_flags & VM_WRITE) return -EPERM; + vma->vm_flags &= ~VM_MAYWRITE; if (!dev->mdev->clock_info_page) return -EOPNOTSUPP; @@ -2237,6 +2238,7 @@ static int mlx5_ib_mmap(struct ib_ucontext *ibcontext, struct vm_area_struct *vm if (vma->vm_flags & VM_WRITE) return -EPERM; + vma->vm_flags &= ~VM_MAYWRITE; /* Don't expose to user-space information it shouldn't have */ if (PAGE_SIZE > 4096) -- 2.20.1