From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, UNWANTED_LANGUAGE_BODY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1E46C10F13 for ; Tue, 16 Apr 2019 14:04:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 94698223C0 for ; Tue, 16 Apr 2019 14:04:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728705AbfDPOEz (ORCPT ); Tue, 16 Apr 2019 10:04:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45746 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726641AbfDPOEz (ORCPT ); Tue, 16 Apr 2019 10:04:55 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E2E18307EAA1; Tue, 16 Apr 2019 14:04:54 +0000 (UTC) Received: from localhost.localdomain (ovpn-116-56.ams2.redhat.com [10.36.116.56]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8532D5D9CA; Tue, 16 Apr 2019 14:04:53 +0000 (UTC) From: Beniamino Galvani To: netdev@vger.kernel.org Cc: Andrea Claudi , Serhey Popovych Subject: [PATCH iproute2] ip: add missing space after 'external' in detailed mode Date: Tue, 16 Apr 2019 16:04:39 +0200 Message-Id: <20190416140439.25569-1-bgalvani@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Tue, 16 Apr 2019 14:04:54 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Add a missing space after the 'external' keyword in the detailed mode of tunnel links output: # ip -d link 79: geneve1: mtu 65465 qdisc noop state DOWN mode DEFAULT group default qlen 1000 link/ether da:e9:e4:2b:f9:d4 brd ff:ff:ff:ff:ff:ff promiscuity 0 minmtu 68 maxmtu 65465 geneve externaladdrgenmode eui64 numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535 80: vxlan1: mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000 link/ether 7a:a8:19:07:da:01 brd ff:ff:ff:ff:ff:ff promiscuity 0 minmtu 68 maxmtu 65535 vxlan externaladdrgenmode eui64 numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535 84: gre1@NONE: mtu 1476 qdisc noop state DOWN mode DEFAULT group default qlen 1000 link/none 00:00:00:00 brd 00:00:00:00 promiscuity 0 minmtu 0 maxmtu 0 gre externaladdrgenmode eui64 numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535 87: ip6gre1@NONE: mtu 1448 qdisc noop state DOWN mode DEFAULT group default qlen 1000 link/gre6 :: brd :: promiscuity 0 minmtu 0 maxmtu 0 ip6gre externaladdrgenmode eui64 numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535 88: ip6tnl1@NONE: mtu 1452 qdisc noop state DOWN mode DEFAULT group default qlen 1000 link/tunnel6 :: brd :: promiscuity 0 minmtu 68 maxmtu 65407 ip6tnl externaladdrgenmode eui64 numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535 90: ipip1@NONE: mtu 1480 qdisc noop state DOWN mode DEFAULT group default qlen 1000 link/ipip 0.0.0.0 brd 0.0.0.0 promiscuity 0 minmtu 0 maxmtu 0 ipip externaladdrgenmode eui64 numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535 Fixes: 00ff4b8e31af ("ip/tunnel: Be consistent when printing tunnel collect metadata") Reviewed-and-tested-by: Andrea Claudi Signed-off-by: Beniamino Galvani --- ip/iplink_geneve.c | 2 +- ip/iplink_vxlan.c | 2 +- ip/link_gre.c | 2 +- ip/link_gre6.c | 2 +- ip/link_ip6tnl.c | 2 +- ip/link_iptnl.c | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/ip/iplink_geneve.c b/ip/iplink_geneve.c index 278a6e23..d70b1941 100644 --- a/ip/iplink_geneve.c +++ b/ip/iplink_geneve.c @@ -251,7 +251,7 @@ static void geneve_print_opt(struct link_util *lu, FILE *f, struct rtattr *tb[]) return; if (tb[IFLA_GENEVE_COLLECT_METADATA]) { - print_bool(PRINT_ANY, "external", "external", true); + print_bool(PRINT_ANY, "external", "external ", true); return; } diff --git a/ip/iplink_vxlan.c b/ip/iplink_vxlan.c index 497affc0..1489c009 100644 --- a/ip/iplink_vxlan.c +++ b/ip/iplink_vxlan.c @@ -418,7 +418,7 @@ static void vxlan_print_opt(struct link_util *lu, FILE *f, struct rtattr *tb[]) if (tb[IFLA_VXLAN_COLLECT_METADATA] && rta_getattr_u8(tb[IFLA_VXLAN_COLLECT_METADATA])) { - print_bool(PRINT_ANY, "external", "external", true); + print_bool(PRINT_ANY, "external", "external ", true); return; } diff --git a/ip/link_gre.c b/ip/link_gre.c index d754fa9a..842fab5c 100644 --- a/ip/link_gre.c +++ b/ip/link_gre.c @@ -436,7 +436,7 @@ static void gre_print_opt(struct link_util *lu, FILE *f, struct rtattr *tb[]) return; if (tb[IFLA_GRE_COLLECT_METADATA]) { - print_bool(PRINT_ANY, "external", "external", true); + print_bool(PRINT_ANY, "external", "external ", true); return; } diff --git a/ip/link_gre6.c b/ip/link_gre6.c index 6c4671e5..4710b404 100644 --- a/ip/link_gre6.c +++ b/ip/link_gre6.c @@ -465,7 +465,7 @@ static void gre_print_opt(struct link_util *lu, FILE *f, struct rtattr *tb[]) return; if (tb[IFLA_GRE_COLLECT_METADATA]) { - print_bool(PRINT_ANY, "external", "external", true); + print_bool(PRINT_ANY, "external", "external ", true); return; } diff --git a/ip/link_ip6tnl.c b/ip/link_ip6tnl.c index 711988a1..8d9feab1 100644 --- a/ip/link_ip6tnl.c +++ b/ip/link_ip6tnl.c @@ -354,7 +354,7 @@ static void ip6tunnel_print_opt(struct link_util *lu, FILE *f, struct rtattr *tb return; if (tb[IFLA_IPTUN_COLLECT_METADATA]) { - print_bool(PRINT_ANY, "external", "external", true); + print_bool(PRINT_ANY, "external", "external ", true); return; } diff --git a/ip/link_iptnl.c b/ip/link_iptnl.c index d4a56de4..2736ef89 100644 --- a/ip/link_iptnl.c +++ b/ip/link_iptnl.c @@ -374,7 +374,7 @@ static void iptunnel_print_opt(struct link_util *lu, FILE *f, struct rtattr *tb[ return; if (tb[IFLA_IPTUN_COLLECT_METADATA]) { - print_bool(PRINT_ANY, "external", "external", true); + print_bool(PRINT_ANY, "external", "external ", true); return; } -- 2.20.1