From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D19E8C10F13 for ; Tue, 16 Apr 2019 22:26:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 971502073F for ; Tue, 16 Apr 2019 22:26:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="4dXVbuhA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727864AbfDPWZ7 (ORCPT ); Tue, 16 Apr 2019 18:25:59 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:35571 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726631AbfDPWZ7 (ORCPT ); Tue, 16 Apr 2019 18:25:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=bQ/v5uq8cgACfGj1hiUR0Jr+19FskuPkXwU5hsVahVc=; b=4dXVbuhAVXhykptmy2a7jfi0zr PhpoZmfRL7U2iS1HKMzhgVK8pzvA8VeOCo+hiYM7GSAxmcJUkhUi5wkgaplz4GX49ryo2bxb3DK30 79sTsSMWV4KZ2SaxlyqqArRJTOFgs5Rek30lcMkh4V+ykwXtQlPdd/8L2F0/NMhb5rwE=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hGWWX-0006ht-TF; Wed, 17 Apr 2019 00:25:53 +0200 Date: Wed, 17 Apr 2019 00:25:53 +0200 From: Andrew Lunn To: Heiner Kallweit Cc: Florian Fainelli , David Miller , "netdev@vger.kernel.org" Subject: Re: [PATCH net-next] net: phy: bcm87xx: improve feature configuration Message-ID: <20190416222553.GA25164@lunn.ch> References: <09a26e61-aa21-8be7-0f51-38897abb2f7b@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <09a26e61-aa21-8be7-0f51-38897abb2f7b@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > @@ -194,7 +191,7 @@ static struct phy_driver bcm87xx_driver[] = { > .phy_id = PHY_ID_BCM8706, > .phy_id_mask = 0xffffffff, > .name = "Broadcom BCM8706", > - .features = PHY_10GBIT_FEC_FEATURES, > + .get_features = bcm87xx_get_features, > .config_init = bcm87xx_config_init, > .config_aneg = bcm87xx_config_aneg, > .read_status = bcm87xx_read_status, > @@ -206,7 +203,7 @@ static struct phy_driver bcm87xx_driver[] = { > .phy_id = PHY_ID_BCM8727, > .phy_id_mask = 0xffffffff, > .name = "Broadcom BCM8727", > - .features = PHY_10GBIT_FEC_FEATURES, > + .get_features = bcm87xx_get_features, > .config_init = bcm87xx_config_init, > .config_aneg = bcm87xx_config_aneg, > .read_status = bcm87xx_read_status, Hi Heiner The product briefs for these two devices say: MDIO interface compliant to IEEE802.3ae Clause 45 with extended indirect address register access It might be possible to just detect most of this? Florian: Do you have access to any boards using these devices? Andrew