From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B20ECC282DA for ; Wed, 17 Apr 2019 17:46:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8B32D206B6 for ; Wed, 17 Apr 2019 17:46:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731218AbfDQRqt (ORCPT ); Wed, 17 Apr 2019 13:46:49 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:57092 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726365AbfDQRqt (ORCPT ); Wed, 17 Apr 2019 13:46:49 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 6CEAC10346CC5; Wed, 17 Apr 2019 10:46:48 -0700 (PDT) Date: Wed, 17 Apr 2019 10:46:47 -0700 (PDT) Message-Id: <20190417.104647.29599416293735161.davem@davemloft.net> To: ssuryaextr@gmail.com Cc: netdev@vger.kernel.org, brouer@redhat.com Subject: Re: [PATCH net-next,v2] ipv6: Add rate limit mask for ICMPv6 messages From: David Miller In-Reply-To: <20190416003157.3621-1-ssuryaextr@gmail.com> References: <20190416003157.3621-1-ssuryaextr@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 17 Apr 2019 10:46:48 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Stephen Suryaputra Date: Mon, 15 Apr 2019 20:31:57 -0400 > @@ -850,6 +850,14 @@ static int __net_init inet6_net_init(struct net *net) > net->ipv6.sysctl.icmpv6_echo_ignore_all = 0; > net->ipv6.sysctl.icmpv6_echo_ignore_multicast = 0; > net->ipv6.sysctl.icmpv6_echo_ignore_anycast = 0; > + net->ipv6.sysctl.icmpv6_ratemask = kzalloc(ICMPV6_MSG_MAX + 1, GFP_KERNEL); > + if (net->ipv6.sysctl.icmpv6_ratemask) { > + /* By default, rate limit error messages. > + * Except for pmtu discovery, it would break it. > + */ > + bitmap_set(net->ipv6.sysctl.icmpv6_ratemask, 0, ICMPV6_ERRMSG_MAX + 1); > + bitmap_clear(net->ipv6.sysctl.icmpv6_ratemask, ICMPV6_PKT_TOOBIG, 1); > + } You're allocating space for ICMPV6_MSG_MAX + 1 "bytes" but you only need enough space for that many "bits". Which is just four 64-bit words, so you can probably inline it.