From: Maxime Ripard <maxime.ripard@bootlin.com>
To: "Petr Štetiar" <ynezz@true.cz>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>, Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Frank Rowand <frowand.list@gmail.com>,
John Crispin <john@phrozen.org>, Felix Fietkau <nbd@nbd.name>
Subject: Re: [PATCH] of_net: add mtd-mac-address support to of_get_mac_address()
Date: Wed, 17 Apr 2019 10:06:14 +0200 [thread overview]
Message-ID: <20190417080614.edt25ynuvae5fn64@flea> (raw)
In-Reply-To: <1555445100-30936-1-git-send-email-ynezz@true.cz>
[-- Attachment #1: Type: text/plain, Size: 1353 bytes --]
On Tue, Apr 16, 2019 at 10:05:00PM +0200, Petr Štetiar wrote:
> From: John Crispin <john@phrozen.org>
>
> Many embedded devices have information such as MAC addresses stored
> inside MTD devices. This patch allows us to add a property inside a node
> describing a network interface. The new property points at a MTD
> partition with an offset where the MAC address can be found.
>
> This patch has originated in OpenWrt some time ago, so in order to
> consider usefulness of this patch, here are some real-world numbers
> which hopefully speak for themselves:
>
> * mtd-mac-address used 497 times in 357 device tree files
> * mtd-mac-address-increment used 74 times in 58 device tree files
> * mtd-mac-address-increment-byte used 1 time in 1 device tree file
>
> Signed-off-by: John Crispin <john@phrozen.org>
> Signed-off-by: Felix Fietkau <nbd@nbd.name>
> [cleanup of the patch for upstream submission]
> Signed-off-by: Petr Štetiar <ynezz@true.cz>
NVMEM is supported by of_net already and there's an MTD-to-nvmem
bridge already, so it doesn't look really necessary to create
additional properties that cover the same use case.
(or at least, you should explain why nvmem doesn't work there)
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2019-04-17 8:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 20:05 [PATCH] of_net: add mtd-mac-address support to of_get_mac_address() Petr Štetiar
2019-04-17 0:29 ` Florian Fainelli
2019-04-17 3:01 ` Frank Rowand
2019-04-30 0:48 ` Rob Herring
2019-04-30 1:15 ` Frank Rowand
2019-04-17 5:00 ` Heiner Kallweit
2019-04-17 8:06 ` Maxime Ripard [this message]
2019-04-17 9:49 ` Petr Štetiar
2019-04-17 10:15 ` Maxime Ripard
2019-04-17 12:10 ` Petr Štetiar
2019-04-17 16:06 ` Petr Štetiar
2019-04-17 18:05 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190417080614.edt25ynuvae5fn64@flea \
--to=maxime.ripard@bootlin.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=frowand.list@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=john@phrozen.org \
--cc=mark.rutland@arm.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=ynezz@true.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).