From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C60CEC10F12 for ; Wed, 17 Apr 2019 08:06:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A0554206BA for ; Wed, 17 Apr 2019 08:06:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731253AbfDQIGT (ORCPT ); Wed, 17 Apr 2019 04:06:19 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:54757 "EHLO relay6-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728373AbfDQIGT (ORCPT ); Wed, 17 Apr 2019 04:06:19 -0400 X-Originating-IP: 90.88.160.238 Received: from localhost (aaubervilliers-681-1-42-238.w90-88.abo.wanadoo.fr [90.88.160.238]) (Authenticated sender: maxime.ripard@bootlin.com) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 1FA9DC0031; Wed, 17 Apr 2019 08:06:14 +0000 (UTC) Date: Wed, 17 Apr 2019 10:06:14 +0200 From: Maxime Ripard To: Petr =?utf-8?Q?=C5=A0tetiar?= Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, "David S. Miller" , Rob Herring , Mark Rutland , Andrew Lunn , Florian Fainelli , Heiner Kallweit , Frank Rowand , John Crispin , Felix Fietkau Subject: Re: [PATCH] of_net: add mtd-mac-address support to of_get_mac_address() Message-ID: <20190417080614.edt25ynuvae5fn64@flea> References: <1555445100-30936-1-git-send-email-ynezz@true.cz> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="gikqjjwjdxbksuco" Content-Disposition: inline In-Reply-To: <1555445100-30936-1-git-send-email-ynezz@true.cz> User-Agent: NeoMutt/20180716 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org --gikqjjwjdxbksuco Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 16, 2019 at 10:05:00PM +0200, Petr =C5=A0tetiar wrote: > From: John Crispin > > Many embedded devices have information such as MAC addresses stored > inside MTD devices. This patch allows us to add a property inside a node > describing a network interface. The new property points at a MTD > partition with an offset where the MAC address can be found. > > This patch has originated in OpenWrt some time ago, so in order to > consider usefulness of this patch, here are some real-world numbers > which hopefully speak for themselves: > > * mtd-mac-address used 497 times in 357 device tree files > * mtd-mac-address-increment used 74 times in 58 device tree files > * mtd-mac-address-increment-byte used 1 time in 1 device tree file > > Signed-off-by: John Crispin > Signed-off-by: Felix Fietkau > [cleanup of the patch for upstream submission] > Signed-off-by: Petr =C5=A0tetiar NVMEM is supported by of_net already and there's an MTD-to-nvmem bridge already, so it doesn't look really necessary to create additional properties that cover the same use case. (or at least, you should explain why nvmem doesn't work there) Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --gikqjjwjdxbksuco Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXLbedgAKCRDj7w1vZxhR xfjmAP0Sw3VBrdt8aaAzhZ5lZKvC/qnMrVYmsV10Tzgtw5IoRgD/UHRzN/MmhDfC JinJb+gd7jZwI1VqGOajMQkcZYta1wQ= =YF+D -----END PGP SIGNATURE----- --gikqjjwjdxbksuco--