From: "Petr Štetiar" <ynezz@true.cz>
To: Maxime Ripard <maxime.ripard@bootlin.com>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>, Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Frank Rowand <frowand.list@gmail.com>,
John Crispin <john@phrozen.org>, Felix Fietkau <nbd@nbd.name>
Subject: Re: [PATCH] of_net: add mtd-mac-address support to of_get_mac_address()
Date: Wed, 17 Apr 2019 14:10:44 +0200 [thread overview]
Message-ID: <20190417121044.GC79403@meh.true.cz> (raw)
In-Reply-To: <20190417101557.6jicrn56dqaccxar@flea>
Maxime Ripard <maxime.ripard@bootlin.com> [2019-04-17 12:15:57]:
> https://elixir.bootlin.com/linux/latest/source/net/ethernet/eth.c#L564
Thanks, so if I parse those 2 use cases of nvmem_get_mac_address correctly:
drivers/net/ethernet/cadence/macb_main.c: err = nvmem_get_mac_address(&pdev->dev, bp->dev->dev_addr);
drivers/net/ethernet/ti/davinci_emac.c: rc = nvmem_get_mac_address(&pdev->dev, priv->mac_addr);
We would need to spill `nvmem_get_mac_address` into every single driver on
earth (as it's done now in those two drivers I've mentioned above) which would
like to use MAC address stored in NVME or wire `nvmem_get_mac_address` into
`of_get_mac_address`, right?
-- ynezz
next prev parent reply other threads:[~2019-04-17 12:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 20:05 [PATCH] of_net: add mtd-mac-address support to of_get_mac_address() Petr Štetiar
2019-04-17 0:29 ` Florian Fainelli
2019-04-17 3:01 ` Frank Rowand
2019-04-30 0:48 ` Rob Herring
2019-04-30 1:15 ` Frank Rowand
2019-04-17 5:00 ` Heiner Kallweit
2019-04-17 8:06 ` Maxime Ripard
2019-04-17 9:49 ` Petr Štetiar
2019-04-17 10:15 ` Maxime Ripard
2019-04-17 12:10 ` Petr Štetiar [this message]
2019-04-17 16:06 ` Petr Štetiar
2019-04-17 18:05 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190417121044.GC79403@meh.true.cz \
--to=ynezz@true.cz \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=frowand.list@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=john@phrozen.org \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@bootlin.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).