netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Cc: netdev@vger.kernel.org, roopa@cumulusnetworks.com,
	dsa@cumulusnetworks.com
Subject: Re: [PATCH iproute2] bridge: mdb: restore valid json output
Date: Wed, 17 Apr 2019 16:35:52 -0700	[thread overview]
Message-ID: <20190417163552.2563376a@hermes.lan> (raw)
In-Reply-To: <20190412153055.8111-1-nikolay@cumulusnetworks.com>

On Fri, 12 Apr 2019 18:30:55 +0300
Nikolay Aleksandrov <nikolay@cumulusnetworks.com> wrote:

> Since the commit below mdb's json output has been invalid and also with
> changed format. Restore it to a valid json like the previous format.
> Also takes care of a double "Deleted" print when monitoring for changes.
> 
> Example bridge -p -d -j mdb show:
>  [ {
>         "mdb": [ {
>                 "index": 4,
>                 "dev": "virbr0",
>                 "port": "vnet2",
>                 "grp": "ff02::202",
>                 "state": "temp",
>                 "flags": [ ]
>             },{
>                 "index": 4,
>                 "dev": "virbr0",
>                 "port": "vnet2",
>                 "grp": "ff02::1:fffb:1939",
>                 "state": "temp",
>                 "flags": [ ]
>             },{
>                 "index": 6,
>                 "dev": "virbr1",
>                 "port": "vnet7",
>                 "grp": "ff02::202",
>                 "state": "temp",
>                 "flags": [ ]
>             },{
>                 "index": 6,
>                 "dev": "virbr1",
>                 "port": "vnet7",
>                 "grp": "ff02::1:ffd0:f61f",
>                 "state": "temp",
>                 "flags": [ ]
>             } ],
>         "router": {
>             "virbr0": [ {
>                     "port": "vnet1"
>                 },{
>                     "port": "vnet0"
>                 } ],
>             "virbr1": [ {
>                     "port": "vnet5"
>                 } ]
>         }
>     } ]
> 
> Fixes: c7c1a1ef51ae ("bridge: colorize output and use JSON print library")
> Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>

Applied, thanks for fixing up my mess from using JSON here.


      reply	other threads:[~2019-04-17 23:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-05 12:59 bridge mdb json output broken/invalid Nikolay Aleksandrov
2019-04-05 16:52 ` Stephen Hemminger
2019-04-12 15:30   ` [PATCH iproute2] bridge: mdb: restore valid json output Nikolay Aleksandrov
2019-04-17 23:35     ` Stephen Hemminger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190417163552.2563376a@hermes.lan \
    --to=stephen@networkplumber.org \
    --cc=dsa@cumulusnetworks.com \
    --cc=netdev@vger.kernel.org \
    --cc=nikolay@cumulusnetworks.com \
    --cc=roopa@cumulusnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).