From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4543EC282DA for ; Wed, 17 Apr 2019 23:35:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0DD312184B for ; Wed, 17 Apr 2019 23:35:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b="wG74UN0F" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733252AbfDQXf4 (ORCPT ); Wed, 17 Apr 2019 19:35:56 -0400 Received: from mail-pf1-f194.google.com ([209.85.210.194]:33810 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729079AbfDQXfz (ORCPT ); Wed, 17 Apr 2019 19:35:55 -0400 Received: by mail-pf1-f194.google.com with SMTP id b3so206163pfd.1 for ; Wed, 17 Apr 2019 16:35:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IQRL5iU32IfD9kZLsbnDvNm9VCtDnR0gTGNfZ/vrasI=; b=wG74UN0F0FyGVrzilAvm1HUwJsJ005Ew+QRUJQUVoR9YaVPpqQIh2XqCfoN7GQVcKP XzlfXJjdNzyZevTGKr2XzUajrBFfHfRw/BU3e29teONDjEAohWjj8/Kdx4XOr19qKqLW 9nji6Y7fv7aaXIW0+WMbpN5TbIFauzjpT++FgrbTN6sFBmhEOrQpYUsWQ2eLpzwIHk2H rZfNu3jVXnSpaLkBWYWhbPGKnJUARB3O6IMhkkUtpkR3+Kmg9RZlGc8pK7aNu1xN312+ e88V52U5VqtdV39V82HUmRxL++gOvyQMEUBB7McKz7xKPmeWnCSG/PBdsPyjM1m+KLUw 9zuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IQRL5iU32IfD9kZLsbnDvNm9VCtDnR0gTGNfZ/vrasI=; b=sh6LnwxQBxbJEG8kx21MEeapa+dPj+gRgQoKwHMKi0/5CZYyLJsyLjGh4PWwpYBVLt Gu3hdix17/sjdXxnZOCq5XBfmwp2FObM1rcNWTk11FfQfXfcZExIKPZBOah0F7XWQlJb RVmYrCJQc4r2aOi6xLOw4ZcqsTmOX/4hqe2MtpP++pme9fC5K0bBf640oHdGQFYAk487 2d+Yetx6oeQ+DAiIRr7MhCWtzkZ0eiG2kKYzXg+QvuArqGx8XKE+aPfDexqJ+HnSOEUW 20ctHC/fQTxNrizeohjBzoDk4JWqheULaWBU7rIuOFBuqlC3hDP+VffNyIC0F7Sl9uwG x2ug== X-Gm-Message-State: APjAAAVH4yxKuF+mh2MzrIGPLRFEnFy1aKun9Bookc3peYImQyRgj0ti ZkhXNL0O1wH0RawKctDMhpzJ7w== X-Google-Smtp-Source: APXvYqw9JsTXCEj31jSoXphtV5S+Cdy43OqjSO3TM8UJqRCIr2KVNE1jGWXvs0v/baMt0euAKNE1kw== X-Received: by 2002:a62:fb0a:: with SMTP id x10mr93402689pfm.179.1555544155236; Wed, 17 Apr 2019 16:35:55 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id x24sm358841pfn.128.2019.04.17.16.35.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 17 Apr 2019 16:35:55 -0700 (PDT) Date: Wed, 17 Apr 2019 16:35:52 -0700 From: Stephen Hemminger To: Nikolay Aleksandrov Cc: netdev@vger.kernel.org, roopa@cumulusnetworks.com, dsa@cumulusnetworks.com Subject: Re: [PATCH iproute2] bridge: mdb: restore valid json output Message-ID: <20190417163552.2563376a@hermes.lan> In-Reply-To: <20190412153055.8111-1-nikolay@cumulusnetworks.com> References: <20190405095259.6ca08f67@shemminger-XPS-13-9360> <20190412153055.8111-1-nikolay@cumulusnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 12 Apr 2019 18:30:55 +0300 Nikolay Aleksandrov wrote: > Since the commit below mdb's json output has been invalid and also with > changed format. Restore it to a valid json like the previous format. > Also takes care of a double "Deleted" print when monitoring for changes. > > Example bridge -p -d -j mdb show: > [ { > "mdb": [ { > "index": 4, > "dev": "virbr0", > "port": "vnet2", > "grp": "ff02::202", > "state": "temp", > "flags": [ ] > },{ > "index": 4, > "dev": "virbr0", > "port": "vnet2", > "grp": "ff02::1:fffb:1939", > "state": "temp", > "flags": [ ] > },{ > "index": 6, > "dev": "virbr1", > "port": "vnet7", > "grp": "ff02::202", > "state": "temp", > "flags": [ ] > },{ > "index": 6, > "dev": "virbr1", > "port": "vnet7", > "grp": "ff02::1:ffd0:f61f", > "state": "temp", > "flags": [ ] > } ], > "router": { > "virbr0": [ { > "port": "vnet1" > },{ > "port": "vnet0" > } ], > "virbr1": [ { > "port": "vnet5" > } ] > } > } ] > > Fixes: c7c1a1ef51ae ("bridge: colorize output and use JSON print library") > Signed-off-by: Nikolay Aleksandrov Applied, thanks for fixing up my mess from using JSON here.