From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25F57C282DA for ; Wed, 17 Apr 2019 18:14:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E85AC20652 for ; Wed, 17 Apr 2019 18:14:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="P1E7Cnzm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729563AbfDQSOD (ORCPT ); Wed, 17 Apr 2019 14:14:03 -0400 Received: from mail-it1-f196.google.com ([209.85.166.196]:55834 "EHLO mail-it1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725848AbfDQSOD (ORCPT ); Wed, 17 Apr 2019 14:14:03 -0400 Received: by mail-it1-f196.google.com with SMTP id y134so6240773itc.5 for ; Wed, 17 Apr 2019 11:14:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=dY7tYFYKFkHObUQsM9lhcH4iEeWsYVDH1hhmZQn80Os=; b=P1E7CnzmN4c9IQs8QLRAcsV5/iDpaHG+pteZR4dqY7bykpIzm/aCv+8zIwTp/4X+Uk UkqDpNJNg/Ofy4e2cAHVpslTtRZGANhDR/9/RthLjpYUTIDCnRKoTXVPpWh1+NhdJrZL UsfsdNjyxO0838/UU7L2bT1vlfzOYY5uylQBRItO7jHABWjlyioWjMS1VnQgmuZFKQKK JOU+lM9j0FEQt2dKm84SFsvb10KKukhDReAqkD72CqciR9u1vOjrUk6vLhpoZYNoxTyU LTHTOm2PdfYRX4HERj2SDNP976DHYDSotY+bPmxuHmACpiAJ9VLTS4CRZdsoTzjorzVk Hk8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=dY7tYFYKFkHObUQsM9lhcH4iEeWsYVDH1hhmZQn80Os=; b=lsUwBductqlQoa2W639hm3T2GVAwii0wBt7Jlz2ldxP3pah8TV7r4hOIOa5sl2BtQs F+H2SDmYgMOASN1gV0+ZQ1AEuOXwj13SOxeetCkc7qhMO2R8qWFY/QcTHrwH6no6fj/9 0wBi/C6fh9btQyUL0g3FcN+Pt81+EFN17ikBSuMRGfJmAy+7CivIpAWk/Q9Fpo1ripSR kcWu3F9mk8ktMS2BCgB6vdbuDvb8RbUnBKKAc7r/DbEd0NMD7pCpcMcuNFVQ1TX4LyaQ yZkAZo4lXj2fO70RxkLsSOTz1cbXcKCkCB2mbFlw4UD+9YEha7Vg65pPVC+mJSGxYLLU Zqmw== X-Gm-Message-State: APjAAAVZMJB2/0UASeZEhKxai2EEz+xBOu8P7VL4XeT2XuJ0c//23bmY RknLgltyR1W102fy/K9h+Q== X-Google-Smtp-Source: APXvYqyDHz1/CWaSf5l1x+GdeM6uJrgXncx7HXbRjfUpUS6IzKf9xXeHvJZUVQYINPVnlvaPZCn3ug== X-Received: by 2002:a24:b70b:: with SMTP id h11mr836147itf.98.1555524842454; Wed, 17 Apr 2019 11:14:02 -0700 (PDT) Received: from ubuntu ([12.38.14.10]) by smtp.gmail.com with ESMTPSA id 67sm1655359itz.37.2019.04.17.11.14.01 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 17 Apr 2019 11:14:01 -0700 (PDT) Date: Wed, 17 Apr 2019 14:13:40 -0400 From: Stephen Suryaputra To: David Miller Cc: netdev@vger.kernel.org, brouer@redhat.com Subject: Re: [PATCH net-next,v2] ipv6: Add rate limit mask for ICMPv6 messages Message-ID: <20190417181340.GA5565@ubuntu> References: <20190416003157.3621-1-ssuryaextr@gmail.com> <20190417.104647.29599416293735161.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190417.104647.29599416293735161.davem@davemloft.net> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Apr 17, 2019 at 10:46:47AM -0700, David Miller wrote: > From: Stephen Suryaputra > Date: Mon, 15 Apr 2019 20:31:57 -0400 > > > @@ -850,6 +850,14 @@ static int __net_init inet6_net_init(struct net *net) > > net->ipv6.sysctl.icmpv6_echo_ignore_all = 0; > > net->ipv6.sysctl.icmpv6_echo_ignore_multicast = 0; > > net->ipv6.sysctl.icmpv6_echo_ignore_anycast = 0; > > + net->ipv6.sysctl.icmpv6_ratemask = kzalloc(ICMPV6_MSG_MAX + 1, GFP_KERNEL); > > + if (net->ipv6.sysctl.icmpv6_ratemask) { > > + /* By default, rate limit error messages. > > + * Except for pmtu discovery, it would break it. > > + */ > > + bitmap_set(net->ipv6.sysctl.icmpv6_ratemask, 0, ICMPV6_ERRMSG_MAX + 1); > > + bitmap_clear(net->ipv6.sysctl.icmpv6_ratemask, ICMPV6_PKT_TOOBIG, 1); > > + } > > You're allocating space for ICMPV6_MSG_MAX + 1 "bytes" but you only need enough space > for that many "bits". Which is just four 64-bit words, so you can probably inline it. Doh, I thought I have divided it by 8. I will fix this and probably inline it. Thanks.