From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1361C282DA for ; Wed, 17 Apr 2019 20:52:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AC48C2183E for ; Wed, 17 Apr 2019 20:52:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="trLWo2tR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732622AbfDQUwP (ORCPT ); Wed, 17 Apr 2019 16:52:15 -0400 Received: from mail-qt1-f194.google.com ([209.85.160.194]:37580 "EHLO mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729939AbfDQUwO (ORCPT ); Wed, 17 Apr 2019 16:52:14 -0400 Received: by mail-qt1-f194.google.com with SMTP id z16so29033779qtn.4 for ; Wed, 17 Apr 2019 13:52:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=s+dZLiLdrn/m7pm2f8aJAETt4fXWtez1/ZLyI28Fxkg=; b=trLWo2tRAGvavHyqm9OxyVTtgwgCEaiH4/z5kEqlMBhAQCo7P67zN6/IGXB9YzVhdS IOQPO/VbCF3qRoo36S+sB9M+1zmZK7txLe88fhNKodJHOxNhMqeugJu+8EzTce31ThLe sBe/9F1PH+AKaynDOYOrHWQVtcLXK0w69HE5qIEi0hy9NkYJiwmqh0LdMZ8TS3gY0kx3 EP/Hjqh2WDEL28OqW4LyHffb+j4B9sIC6Zz24wiFUz1lHSQnghX4DAcCUj9KxlZ4Jtad TLCF4RTi2c7ZISxBfjU8UsG/dJq5FDGNgzJ13hMFLiogZXqqiOpOv6KBtt7dMEcMCdQM 7qMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=s+dZLiLdrn/m7pm2f8aJAETt4fXWtez1/ZLyI28Fxkg=; b=pfH7iKY9hoXfIV9XnyAiV1eipREqohgj6MULmpU2HwLTkJkjdWU5IR561pO2yXPnJO VB0GcfF5fsoSBggt8rR7pUb4hIKIoWtca8rGLmuMasIVKXdQgIGMQnyC7gIi8uk7V8GU 8C80OMISRkg2j3V64vStOVarWifkK6UBtIbdsjLRSCGot8LAZZbHpCTGV1aCHHet46LL +3Aa4PkmiTG+X8rejwUH+mmbtU1pcGs7tLrJVhDf4ichw4B4A81hWUUYxFG5GkMYJtOL qVBBjTFF4xAqZaV6mZ76qNZ8YDVTlEuHMhgEa8ursj6rt/Toj0FA89SCdv7fwOdXh8s7 DK8w== X-Gm-Message-State: APjAAAWAlOUOMKeGbUr4PFfkCSGfz2+SLpOTcOC0FObUnDBbcUS8lQA9 vRlPa/exAgAfeIZ0y4tdA24prQ== X-Google-Smtp-Source: APXvYqyl6LUIRRj5YGngxsCWh/OkmMClkmqxmohbiqitq4OxcMeiCuTbfyMWRY+ZaRANjJk1IjGsyw== X-Received: by 2002:ac8:1767:: with SMTP id u36mr70527986qtk.143.1555534333832; Wed, 17 Apr 2019 13:52:13 -0700 (PDT) Received: from jkicinski-Precision-T1700.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id d34sm60247qta.18.2019.04.17.13.52.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 17 Apr 2019 13:52:13 -0700 (PDT) From: Jakub Kicinski To: davem@davemloft.net Cc: netdev@vger.kernel.org, oss-drivers@netronome.com, Jakub Kicinski , Dirk van der Merwe Subject: [PATCH net-next 2/5] sb1000: fix variable set but not used warnings Date: Wed, 17 Apr 2019 13:51:56 -0700 Message-Id: <20190417205159.30938-3-jakub.kicinski@netronome.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190417205159.30938-1-jakub.kicinski@netronome.com> References: <20190417205159.30938-1-jakub.kicinski@netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org GCC 8 complains: drivers/net/sb1000.c: In function ‘card_send_command’: drivers/net/sb1000.c:319:14: warning: variable ‘x’ set but not used [-Wunused-but-set-variable] int status, x; ^ drivers/net/sb1000.c: In function ‘sb1000_check_CRC’: drivers/net/sb1000.c:493:6: warning: variable ‘crc’ set but not used [-Wunused-but-set-variable] int crc, status; ^~~ Signed-off-by: Jakub Kicinski Reviewed-by: Dirk van der Merwe --- drivers/net/sb1000.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/net/sb1000.c b/drivers/net/sb1000.c index 941cfa8f1c2a..627b3a4405ad 100644 --- a/drivers/net/sb1000.c +++ b/drivers/net/sb1000.c @@ -316,7 +316,7 @@ static int card_send_command(const int ioaddr[], const char* name, const unsigned char out[], unsigned char in[]) { - int status, x; + int status; if ((status = card_wait_for_busy_clear(ioaddr, name))) return status; @@ -345,9 +345,7 @@ card_send_command(const int ioaddr[], const char* name, out[0], out[1], out[2], out[3], out[4], out[5]); } - if (out[1] == 0x1b) { - x = (out[2] == 0x02); - } else { + if (out[1] != 0x1b) { if (out[0] >= 0x80 && in[0] != (out[1] | 0x80)) return -EIO; } @@ -490,14 +488,13 @@ sb1000_check_CRC(const int ioaddr[], const char* name) static const unsigned char Command0[6] = {0x80, 0x1f, 0x00, 0x00, 0x00, 0x00}; unsigned char st[7]; - int crc, status; + int status; /* check CRC */ if ((status = card_send_command(ioaddr, name, Command0, st))) return status; if (st[1] != st[3] || st[2] != st[4]) return -EIO; - crc = st[1] << 8 | st[2]; return 0; } -- 2.21.0