netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Richard Cochran <richardcochran@gmail.com>
To: Jiri Benc <jbenc@redhat.com>
Cc: Hangbin Liu <liuhangbin@gmail.com>,
	netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
	Miroslav Lichvar <mlichvar@redhat.com>,
	Patrick McHardy <kaber@trash.net>,
	stefan.sorensen@spectralink.com
Subject: Re: [PATCH net-next] macvlan: pass get_ts_info and SIOC[SG]HWTSTAMP ioctl to real device
Date: Wed, 17 Apr 2019 20:31:57 -0700	[thread overview]
Message-ID: <20190418033157.irs25halxnemh65y@localhost> (raw)
In-Reply-To: <20190417205958.6508bda2@redhat.com>

On Wed, Apr 17, 2019 at 08:59:58PM +0200, Jiri Benc wrote:
> The problem here is this patch gives access to physical interface
> settings through a virtual interface layered on top of it. Whenever
> such thing is done, the virtual interface needs to provide a suitable
> way of moderating access to the shared resources, so the individual
> virtual interfaces do not affect each other. That's not what's being
> done here.

So I guess the macvlan should reject SIOCSHWTSTAMP but allow
SIOCGHWTSTAMP.
 
> I think this patch is wrong.

But what about this statement:

    ptp over vlan also has this issue

What is the issue with VLAN interfaces?  Are these exportable to a
container when the physical interface is not?

Thanks,
Richard

  reply	other threads:[~2019-04-18  3:32 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-20  2:23 [PATCH net-next] macvlan: pass get_ts_info and SIOC[SG]HWTSTAMP ioctl to real device Hangbin Liu
2019-03-20 18:05 ` David Miller
2019-04-17  8:05 ` Hangbin Liu
2019-04-17 15:43   ` Richard Cochran
2019-04-17 18:59     ` Jiri Benc
2019-04-18  3:31       ` Richard Cochran [this message]
2019-04-18  6:10         ` Hangbin Liu
2019-04-18  8:05         ` Miroslav Lichvar
2019-04-23  4:18           ` Hangbin Liu
2019-04-23  8:31             ` Miroslav Lichvar
2019-04-23  9:15               ` Hangbin Liu
2019-04-23  9:32                 ` Miroslav Lichvar
2019-04-25 13:40                   ` Hangbin Liu
2019-05-06  7:34                     ` Hangbin Liu
2019-05-06 14:01                     ` Richard Cochran
2019-05-07  8:35                       ` Miroslav Lichvar
2019-05-08  1:41                         ` Hangbin Liu
2019-05-08 13:58                           ` Michal Kubecek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190418033157.irs25halxnemh65y@localhost \
    --to=richardcochran@gmail.com \
    --cc=davem@davemloft.net \
    --cc=jbenc@redhat.com \
    --cc=kaber@trash.net \
    --cc=liuhangbin@gmail.com \
    --cc=mlichvar@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=stefan.sorensen@spectralink.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).