From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73537C282DA for ; Thu, 18 Apr 2019 03:32:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 418F9217F4 for ; Thu, 18 Apr 2019 03:32:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CitUqDrj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387945AbfDRDcB (ORCPT ); Wed, 17 Apr 2019 23:32:01 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:46164 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732183AbfDRDcA (ORCPT ); Wed, 17 Apr 2019 23:32:00 -0400 Received: by mail-pg1-f193.google.com with SMTP id 10so117931pgv.13 for ; Wed, 17 Apr 2019 20:32:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=IhnpvwXc+pSdVLRA4RZv55RxBU1/lX+I58zumUAmxrM=; b=CitUqDrj4RkSZrtONeuDEi8IXX0o3MwwUz1wUO5Arot7vVBtTtGkX3h/FjBt0c+b17 WHSKTL/pT3wpweKZwRmYIdoxJwptcvbSC0S2YOHCAer99EHkS7n2ezEQhu2qQgHtLOqa h37GDDPHX8GEzjAyuAJBFcHjIzq/uIEAeGxHsQ0dl9KqBlOoPjmVlJLviq0Vsuy9CzID kVi26yR5KESjA8n+Iq6AQieM/81YT/co0Dq7YUO/YP0EmWXlc8OjllsaRS87pMQ9jear H2edatsEsr4kBdyyz5MvzUTb5sqBrYCxMQ6Lfb7RquQZz4PNw0q6E1s8m0ffDs3Y/52W Nrqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=IhnpvwXc+pSdVLRA4RZv55RxBU1/lX+I58zumUAmxrM=; b=QLOonWFBpDLwzWKjE0TyXlnEwDbW6alaAqPg0e8Vl2rFe/jE8bO/JlYcEGaCoxL7X3 PX3SdDo4Mr3/BPHNTR88B8VwG6al62LSRZIHSNSe+HFgckSez9G2w9SJBkC2I4TQMi65 nTep2hr2VwI6IhcPAWAT9XuFr+PQBPuPBf0okXh67NAOqrw2J3fAHZ76eGq+p9oPRjcd T7MsYychCcK8r2/cYZID1pTcgnyksZCTvF/1x2jV70zZBJ66M2vxgU09kqf/3QMsL+Og ckBMbcfnZbIwhKOU5QjUGBeoiGpUfKkCE0f41plhZSwyJI2PTwr9Vpue9hznN03tlKeI IWmA== X-Gm-Message-State: APjAAAWxc5PKMLSRUsqLkNy0zX9SUpnzsEzdmMdNoiXg7IjvjYWfk5iV xxYqPlE7unLXk92B6qZu+JPVuZfD X-Google-Smtp-Source: APXvYqxXDqyie7AIm4Qw/2Qns5IfbI9tgYI1s5aFfA68+jNf/smJTCf4wDi0nRBEWvMxyTz57cGakw== X-Received: by 2002:a62:1215:: with SMTP id a21mr92713576pfj.126.1555558320242; Wed, 17 Apr 2019 20:32:00 -0700 (PDT) Received: from localhost (c-73-222-71-142.hsd1.ca.comcast.net. [73.222.71.142]) by smtp.gmail.com with ESMTPSA id g4sm861388pfc.75.2019.04.17.20.31.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 17 Apr 2019 20:31:59 -0700 (PDT) Date: Wed, 17 Apr 2019 20:31:57 -0700 From: Richard Cochran To: Jiri Benc Cc: Hangbin Liu , netdev@vger.kernel.org, David Miller , Miroslav Lichvar , Patrick McHardy , stefan.sorensen@spectralink.com Subject: Re: [PATCH net-next] macvlan: pass get_ts_info and SIOC[SG]HWTSTAMP ioctl to real device Message-ID: <20190418033157.irs25halxnemh65y@localhost> References: <20190320022333.3378-1-liuhangbin@gmail.com> <20190417061452.GA18865@dhcp-12-139.nay.redhat.com> <20190417154306.om6rjkxq4hikhsht@localhost> <20190417205958.6508bda2@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190417205958.6508bda2@redhat.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Apr 17, 2019 at 08:59:58PM +0200, Jiri Benc wrote: > The problem here is this patch gives access to physical interface > settings through a virtual interface layered on top of it. Whenever > such thing is done, the virtual interface needs to provide a suitable > way of moderating access to the shared resources, so the individual > virtual interfaces do not affect each other. That's not what's being > done here. So I guess the macvlan should reject SIOCSHWTSTAMP but allow SIOCGHWTSTAMP. > I think this patch is wrong. But what about this statement: ptp over vlan also has this issue What is the issue with VLAN interfaces? Are these exportable to a container when the physical interface is not? Thanks, Richard