From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FFF6C10F0E for ; Thu, 18 Apr 2019 17:17:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C25732064A for ; Thu, 18 Apr 2019 17:17:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="T08NqLcF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388401AbfDRRR1 (ORCPT ); Thu, 18 Apr 2019 13:17:27 -0400 Received: from mail-qt1-f169.google.com ([209.85.160.169]:38130 "EHLO mail-qt1-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733192AbfDRRR1 (ORCPT ); Thu, 18 Apr 2019 13:17:27 -0400 Received: by mail-qt1-f169.google.com with SMTP id d13so2989756qth.5 for ; Thu, 18 Apr 2019 10:17:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=n4tf+PQL3TM1Bvnkvqf+Ge3ti0l95Q+J3MRJI6P+/F8=; b=T08NqLcFEHod9vU8l4ha/Fnqefi8ENbE/FM3RjuM9OC0fyQYgRKZM1Ao4ZsTIWOSFo UjCl6ZtVKb8M7oq67Cwnt8+F7OPU3htrGKrvKAFE3My+4U/6E3EEujhRBHnYtOCPs8t9 A06ohtfBri17K6abH0akn5TKmn4V79ZeMETCUHbhL0c0KbkDAO1wEjzxq2aIM1KpLsD6 BXe87Jk4CxbIgOyUs+GiGDJsogTSaEIntCu3zBjHU5y16cpJ2l/tuMxPJ7rlvBdanObP IoULAJCXF9ft6l6bmhRecC18uWenJNGrwE2/0ZfoAa3fr3p4TKnvpVWFQWHsf/svrhkF ydLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=n4tf+PQL3TM1Bvnkvqf+Ge3ti0l95Q+J3MRJI6P+/F8=; b=n4x1RASMvtU8eR8/+JHI3Kh7o5Crhnbr92jijIqCdvjvkEj6d5iU1rxU8ilBJLG8li Gq1aHsdzjRyr93CvlVKYcIiKnvLOGjO53WVrzDbXgEebxVUkjukUirR3yeP2ylUsWRxz ROMyvlo1LBh/0tFAcwLEdqzrW9y5S/ar9qQQc5dUM5DVE7epvDuMdWMnke33lSJ79lvG mghnFQItXPFZEnAUjsloEUsvwZmfUT+2pvN4mRz1upJ5hq01DWlbVjgFhQRIi6lS7Nep tVrKmlEvmhiD3hja0vdPsrk3uT2+cXOOdBGF/FPoaT2WceAqMMMAjMSsn+x0bXggjWNQ TkPQ== X-Gm-Message-State: APjAAAXnmguFvfYVLIGcMqUmqJAwN8rXZxKUx8OOsB+X1hajKbBOnZlA aKjIR5XTeRcHw5A8x4fGUo+QHw== X-Google-Smtp-Source: APXvYqwZ8NUc1WT6T9RdkFStqPX5xz8DAgZUU/Rrho/xpqLD/6dHbWDOVbw+Cok9NQFdfU70YskCKA== X-Received: by 2002:ac8:276b:: with SMTP id h40mr78472703qth.319.1555607846567; Thu, 18 Apr 2019 10:17:26 -0700 (PDT) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id a47sm1835911qtb.79.2019.04.18.10.17.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 18 Apr 2019 10:17:26 -0700 (PDT) Date: Thu, 18 Apr 2019 10:17:22 -0700 From: Jakub Kicinski To: Jiri Pirko Cc: netdev@vger.kernel.org, davem@davemloft.net, mlxsw@mellanox.com, dsahern@gmail.com Subject: Re: [patch net-next 03/15] netdevsim: rename devlink.c to dev.c to contain per-dev(asic) items Message-ID: <20190418101722.19af3467@cakuba.netronome.com> In-Reply-To: <20190418140614.3973-4-jiri@resnulli.us> References: <20190418140614.3973-1-jiri@resnulli.us> <20190418140614.3973-4-jiri@resnulli.us> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 18 Apr 2019 16:06:02 +0200, Jiri Pirko wrote: > From: Jiri Pirko > > The existing devlink.c code is going to be extended to represent asic > device on a bus. As this is about more than just devlink, > rename the file. Do appropriate prefix renaming alongside with that. Again, devlink != bus device. I don't like this change at all. Keep them separate, please, unless you _need_ such a change for testing.