From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A925C10F14 for ; Thu, 18 Apr 2019 17:25:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 68EAE217FA for ; Thu, 18 Apr 2019 17:25:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="1C1f/wb0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389803AbfDRRZ5 (ORCPT ); Thu, 18 Apr 2019 13:25:57 -0400 Received: from mail-vk1-f180.google.com ([209.85.221.180]:36238 "EHLO mail-vk1-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388450AbfDRRZ4 (ORCPT ); Thu, 18 Apr 2019 13:25:56 -0400 Received: by mail-vk1-f180.google.com with SMTP id w140so620883vkd.3 for ; Thu, 18 Apr 2019 10:25:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=achf0szITBMw0mjA7VET0rqEYpYA/t1yPYIlDdE5UZ8=; b=1C1f/wb0dONafpyV8cAwL2Y177yK+foEKokgL7mICPkMVt8MGcAYUuygfPgQqRsfT5 tAoU/qTkOtUJ+9+poLTaQ9VdyOYhUkkqhkY2MoPunFa4kq1lsJUSyn/O0QcKLpIQU1Sy BEvXyKuiqoCtN4D9PHYqxzcfs9zj2fp7tQMI+0Ea/nhL7vkfMbujJFu9U3k7fJ8Xmgbi qRe7yGghdXdSpjdgUUXQ92KyFn3rHch5A6lJoOAE6Vklf4+p8AtYSKN9aUf8Hn7bjmms Mj+4EUeSUlWAA0ldt5YwVbY6+CQuIWNhBhH37Ht0eY3ocZ3voFhU1nXnbs7AgLJ7Ywc3 HSeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=achf0szITBMw0mjA7VET0rqEYpYA/t1yPYIlDdE5UZ8=; b=PJEx2QuZ7+yKHFz00COFlLxtpDUIsesoJkwwhgPqU3wHRm+VZOt09vkLuw+ulxfq5h VHSeL9vCNXsbNBk3plYTWtLC8HTcFBd1XXx3Snu3d8nIlg64BzZ6sJ+ceNShwkLYk2go 1gzi8aIY5NHWiuu2HAuF7B5ihYK9WD5AqAeOkNLPc4qxvB8+it3v1FfKqU56DVBso/4g LQv+iosep5oJ0pIt6Kys8VBewyq8SvQlRZ+h3QWp7P4eJfxwgq8vg7Lbtl+q46lYrL8Z wnoSc185/v/fOEMgIlsSuqsC24kgyNejfWXaqPyxoOZNNX6W5rG8UKAcmC6G+GZCizQJ LIaQ== X-Gm-Message-State: APjAAAVynaP4XNrWVhJOXn493BfyNu3QTCjSf/GSov/T2XkrPMVKfPa8 y5S6MHC7EZGLc6JtDi0XbiFDhCNtaLw= X-Google-Smtp-Source: APXvYqx4DtGqXcqb2IS24yT9Pz4BcZ5FwPxkMkese1USTlUzuZdM0KvLrQtyxL0Hp4+lrwSUNubE6w== X-Received: by 2002:ac5:c24b:: with SMTP id n11mr53022324vkk.81.1555608354889; Thu, 18 Apr 2019 10:25:54 -0700 (PDT) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id 187sm1328926vku.45.2019.04.18.10.25.54 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 18 Apr 2019 10:25:54 -0700 (PDT) Date: Thu, 18 Apr 2019 10:25:50 -0700 From: Jakub Kicinski To: Jiri Pirko Cc: netdev@vger.kernel.org, davem@davemloft.net, mlxsw@mellanox.com, dsahern@gmail.com Subject: Re: [patch net-next 14/15] netdevsim: move netdev creation/destruction to dev probe Message-ID: <20190418102550.6eea3255@cakuba.netronome.com> In-Reply-To: <20190418140614.3973-15-jiri@resnulli.us> References: <20190418140614.3973-1-jiri@resnulli.us> <20190418140614.3973-15-jiri@resnulli.us> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 18 Apr 2019 16:06:13 +0200, Jiri Pirko wrote: > @@ -1279,24 +1312,13 @@ try: > start_test("Test multi-dev ASIC cross-dev destruction...") > bpftool_prog_list_wait(expected=2) > > - simA.remove() > + simdevA.remove() > bpftool_prog_list_wait(expected=1) > > ifnameB = bpftool("prog show %s" % (progB))[1]["dev"]["ifname"] > fail(ifnameB != simB1['ifname'], "program not bound to originial device") > - simB1.remove() > - bpftool_prog_list_wait(expected=1) > - > - start_test("Test multi-dev ASIC cross-dev destruction - move...") > - ifnameB = bpftool("prog show %s" % (progB))[1]["dev"]["ifname"] > - fail(ifnameB not in (simB2['ifname'], simB3['ifname']), > - "program not bound to remaining devices") > - > - simB2.remove() > - ifnameB = bpftool("prog show %s" % (progB))[1]["dev"]["ifname"] > - fail(ifnameB != simB3['ifname'], "program not bound to remaining device") > > - simB3.remove() > + simdevB.remove() > bpftool_prog_list_wait(expected=0) > > start_test("Test multi-dev ASIC cross-dev destruction - orphaned...") You're removing existing tests in the name of reshuffling the code? Hard no. Once devlink can do what we need here, we can reorg netdevsim. netdevsim is for testing real interfaces.