From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 878FDC10F0E for ; Thu, 18 Apr 2019 17:46:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4F34520656 for ; Thu, 18 Apr 2019 17:46:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="qgfrHmFE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389742AbfDRRqZ (ORCPT ); Thu, 18 Apr 2019 13:46:25 -0400 Received: from mail-vs1-f67.google.com ([209.85.217.67]:45270 "EHLO mail-vs1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388301AbfDRRqY (ORCPT ); Thu, 18 Apr 2019 13:46:24 -0400 Received: by mail-vs1-f67.google.com with SMTP id o10so1594926vsp.12 for ; Thu, 18 Apr 2019 10:46:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=lj7Hdg0V6duhfZx/XlURDCyH7XkIT/wku+OAckqDI/0=; b=qgfrHmFELpbTyzOxmk28cv22B4IkRwqvMlh0/yv3aaOgs8AxtWMcqLT9pX7bwTpbMt BaenwDWMRkbZMy1YOW4FZ36MSFprcrpxKjP8SgcrKOE/2BBECffGcSBjopds8kWVU2H4 Szs5GA0ExPdPV+L4mSQ59590qtPq1URERkBrF7BwxZaxqaop1eEM8FRwcb0nII0P+Ywm 9Y2MNLBxDFDZreLifZG1oEKVPUfDGw7Wm5DaPDwKdmFaZRCUJZNecVr2KP6wkmoIjxWg nvXz4/lHgCApeEj9ockWhPqkxp4NcZo2crswUQXNpOArbXV/z9b3NfISgr+8oqhUoujq m5Vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=lj7Hdg0V6duhfZx/XlURDCyH7XkIT/wku+OAckqDI/0=; b=J5l5r9nkIifxz4QPzr9QizVNyplqN6tffn+TLgXIUh6nf0sadBGINgg4XFev7gGPT6 eIsiab4fswJfQffI9zLRe1PrBxPvXMih/n5+/6DElufPthAAREDhn6JbKiFaqUTY+EOh NJkQRVsaee6ngDrZf0HASHbQQuxs8xxa9GvuWRb7fT7ylbCJ8BF7PR3DtqXztI5LDGuP r0jaLwRrD4a7GILbSiuhSV1EkimNNjeDo3pTXuzfCgghqestI/IVXGonlOtiDnk5FgQa EoNxBo9AYdIZGvu6aZfBRKXryTodxDcX5+2SDeXrJ/vSPexmNIRpbindy4qUtyV8wV8c jdvQ== X-Gm-Message-State: APjAAAX4OvGja0yzN7mc/z48NFMYluOfQ0imPMIaR3C6M4roFCZW1wI4 C0iR2/8OArKVyEZBqz1twJkBawaAhAk= X-Google-Smtp-Source: APXvYqzYHQNs0OIj8zxuO8U6ByS6JRxqF16mUQ6jAJdXuGBA9rQw7i47eIud4NUdawfauCaVYY6wdw== X-Received: by 2002:a67:89c7:: with SMTP id l190mr53312413vsd.199.1555609583912; Thu, 18 Apr 2019 10:46:23 -0700 (PDT) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id o191sm751480vko.4.2019.04.18.10.46.23 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 18 Apr 2019 10:46:23 -0700 (PDT) Date: Thu, 18 Apr 2019 10:46:19 -0700 From: Jakub Kicinski To: Vlad Buslov Cc: "netdev@vger.kernel.org" , "jhs@mojatatu.com" , "xiyou.wangcong@gmail.com" , "jiri@resnulli.us" , "davem@davemloft.net" Subject: Re: [RFC PATCH net-next] net: sched: flower: refactor reoffload for concurrent access Message-ID: <20190418104619.096a4703@cakuba.netronome.com> In-Reply-To: References: <20190410100014.784a7f9a@cakuba.netronome.com> <20190416142047.3453-1-vladbu@mellanox.com> <20190416144933.4ddb0e68@cakuba.netronome.com> <20190417093432.495dcda6@cakuba.netronome.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 18 Apr 2019 16:33:22 +0000, Vlad Buslov wrote: > Considering this, I tried to improve my solution to remove possibility > of multiple adds of same filter and it seems to me that it would be > enough to move hw_filters list management in flower offloads functions: > add filter to list while holding rtnl lock in fl_hw_replace_filter() and > remove it from list while holding rtnl lock in fl_hw_destroy_filter(). > What do you think? Sounds good for now, but I presume the plan is to get rid of rtnl around the driver call.. at which point we would switch to a rwlock? :)