From: Pablo Neira Ayuso <pablo@netfilter.org>
To: David Miller <davem@davemloft.net>
Cc: fbl@redhat.com, netdev@vger.kernel.org, joe@ovn.org,
pshelar@ovn.org, dev@openvswitch.org,
netfilter-devel@vger.kernel.org
Subject: Re: [PATCH net-next v3 0/4] openvswitch: load and reference the NAT helper
Date: Thu, 18 Apr 2019 13:28:50 +0200 [thread overview]
Message-ID: <20190418112850.6c4e4bolkype5vtf@salvia> (raw)
In-Reply-To: <20190417.232509.1761143873528182624.davem@davemloft.net>
On Wed, Apr 17, 2019 at 11:25:09PM -0700, David Miller wrote:
> From: Flavio Leitner <fbl@redhat.com>
> Date: Wed, 17 Apr 2019 11:46:13 -0300
>
> > The request_module() is quite expensive and triggers the
> > usermode helper in userspace. Instead, load only if the
> > module is not present and keep module references to avoid
> > problems.
> >
> > The first patch standardize the module alias which is already
> > there, but not in a formal way.
> >
> > The second patch adds an API to point to the NAT helper.
> >
> > The third patch will register each NAT helper using the
> > new API.
> >
> > The last patch fixes openvswitch to use the new API to
> > load and reference the NAT helper and also report an error
> > if the operation fails.
>
> Netfilter folks, besides a review, I was wondering if you'd like
> to take this series the netfilter tree since it's mostly changes
> in that area?
I'll place this in the nf-next tree, thanks.
next prev parent reply other threads:[~2019-04-18 11:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-17 14:46 [PATCH net-next v3 0/4] openvswitch: load and reference the NAT helper Flavio Leitner
2019-04-17 14:46 ` [PATCH net-next v3 1/4] netfilter: use macros to create module aliases Flavio Leitner
2019-04-17 14:46 ` [PATCH net-next v3 2/4] netfilter: add API to manage NAT helpers Flavio Leitner
2019-04-17 14:46 ` [PATCH net-next v3 3/4] netfilter: nf_nat: register " Flavio Leitner
2019-04-17 14:46 ` [PATCH net-next v3 4/4] openvswitch: load and reference the NAT helper Flavio Leitner
2019-04-18 6:25 ` [PATCH net-next v3 0/4] " David Miller
2019-04-18 11:28 ` Pablo Neira Ayuso [this message]
2019-04-30 11:42 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190418112850.6c4e4bolkype5vtf@salvia \
--to=pablo@netfilter.org \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=fbl@redhat.com \
--cc=joe@ovn.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pshelar@ovn.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox