From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, oss-drivers@netronome.com,
Guillaume Nault <g.nault@alphalink.fr>
Subject: Re: [PATCH net-next 0/5] net: some build fixes and other improvements
Date: Thu, 18 Apr 2019 17:34:07 -0700 [thread overview]
Message-ID: <20190418173407.3909143b@cakuba.netronome.com> (raw)
In-Reply-To: <20190418.170647.73605480308402367.davem@davemloft.net>
On Thu, 18 Apr 2019 17:06:47 -0700 (PDT), David Miller wrote:
> From: Jakub Kicinski <jakub.kicinski@netronome.com>
> Date: Wed, 17 Apr 2019 13:51:54 -0700
>
> > A few unrelated improvements here, mostly trying to make random
> > configs build and W=1 produce a little less warnings under net/
> > and drivers net/.
> >
> > First two patches fix set but not used warnings with W=1.
> >
> > Next patch fixes 64bit division in sch_taprio.c.
> >
> > Last two patches are getting rid of some (almost) unused asserts
> > in skbuff.h.
>
> Series applied, thanks Jakub.
Thanks!
> That l2tp one was weird, apparently that value was never ever used.
Yess, the only explanation I could come up with was that Guillaume
wanted to make sure user space passed a valid pointer, even if it's
unused today. But that's pure speculation :S
next prev parent reply other threads:[~2019-04-19 0:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-17 20:51 [PATCH net-next 0/5] net: some build fixes and other improvements Jakub Kicinski
2019-04-17 20:51 ` [PATCH net-next 1/5] l2tp: fix set but not used variable Jakub Kicinski
2019-04-17 20:51 ` [PATCH net-next 2/5] sb1000: fix variable set but not used warnings Jakub Kicinski
2019-04-17 20:51 ` [PATCH net-next 3/5] net/sched: taprio: fix build without 64bit div Jakub Kicinski
2019-04-17 22:32 ` Vinicius Costa Gomes
2019-04-30 0:04 ` Leandro Dorileo
2019-04-17 20:51 ` [PATCH net-next 4/5] net: gemini: remove unnecessary assert Jakub Kicinski
2019-04-17 20:51 ` [PATCH net-next 5/5] net: skb: remove unused asserts Jakub Kicinski
2019-04-19 0:06 ` [PATCH net-next 0/5] net: some build fixes and other improvements David Miller
2019-04-19 0:34 ` Jakub Kicinski [this message]
2019-04-19 8:38 ` Guillaume Nault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190418173407.3909143b@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=davem@davemloft.net \
--cc=g.nault@alphalink.fr \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).