From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B0E2C10F14 for ; Fri, 19 Apr 2019 00:34:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 11A14205F4 for ; Fri, 19 Apr 2019 00:34:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="hq6zKNP5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726587AbfDSAeN (ORCPT ); Thu, 18 Apr 2019 20:34:13 -0400 Received: from mail-qt1-f195.google.com ([209.85.160.195]:34230 "EHLO mail-qt1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725939AbfDSAeN (ORCPT ); Thu, 18 Apr 2019 20:34:13 -0400 Received: by mail-qt1-f195.google.com with SMTP id k2so4157209qtm.1 for ; Thu, 18 Apr 2019 17:34:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=zttkNfHp97vFy6DEP/QpqZLJopMXqGfWRsNT+xbZnTg=; b=hq6zKNP5Bomj+ehmvGfYUGZjKh6ziFZnuXSSsr71urreCSUkH0TASOfdWD88g294ZK vsOxI5Jc/wOdk16/njKXlDXjkHwIDmHlXbVG8elY0n+PRkvtwoJk9l5apaISnf3IOq1N vN5ecAy2SHDGhvFcWabrQ1+NvR+zk+HoeHl+dnnDRsRGzH4Yc12Jl3EimdahItwhob/3 oh6yfsAZnIw6/XjxkIq2HrSJyPzGnc9ETKCFWwTypqyXeaQS/mr22Q0Dg89A0+9LwCWY iYa9Fac8x1R3/MHSogIJW/JuAVyn4Rnp1hHvDqDQVtyP02xa7vG2/N3rh6x23/4VznFZ eDKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=zttkNfHp97vFy6DEP/QpqZLJopMXqGfWRsNT+xbZnTg=; b=VuY7d3Mai0sbPc4gQSLhywOh3WF6rsfPof+0yUXzOY/bOU4eDoFTEyQMoOlSoO9Qch /2WSCBvmiHSvnuRnVH0sDhQds7Jh976VTsB4Ppwb5YwRfwe0R1n3WBe5+M3bfSdDMxX+ VY0P3t9p7d008mm7I845IM/LeG9GcYVFbuUNdFJO37OuW+dyTJFJZqkH2B5CFCqt57CA 948py9ECwXj4u38CJhvY5gea4VmtdtFaXD6iiHUhvrk24M0AhbR2LvuEGqXklyVcrRHN lGoH38/lMnJtWiBZy4lcWuRZ1Tcgqmg3H8BatNVIGrfpTNCsCjqQ4hxg92LWR/YuDkTG 3VOg== X-Gm-Message-State: APjAAAVMhG7CupLl8a5TAKOA36bHQO1g4OOp0n0eCwitqMj6j30ea0GK TrbEZIsCC48N+kF64cKpNWPUkA== X-Google-Smtp-Source: APXvYqxBo/8P6K43R3C4ll7LMzUbijpzAwtnZfY9ZMyCFfrMpSj7Y7fZCYH1nUJZxnfpFnX+ETwJvg== X-Received: by 2002:a0c:b012:: with SMTP id k18mr1010986qvc.243.1555634052386; Thu, 18 Apr 2019 17:34:12 -0700 (PDT) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id j8sm206921qki.7.2019.04.18.17.34.11 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 18 Apr 2019 17:34:12 -0700 (PDT) Date: Thu, 18 Apr 2019 17:34:07 -0700 From: Jakub Kicinski To: David Miller Cc: netdev@vger.kernel.org, oss-drivers@netronome.com, Guillaume Nault Subject: Re: [PATCH net-next 0/5] net: some build fixes and other improvements Message-ID: <20190418173407.3909143b@cakuba.netronome.com> In-Reply-To: <20190418.170647.73605480308402367.davem@davemloft.net> References: <20190417205159.30938-1-jakub.kicinski@netronome.com> <20190418.170647.73605480308402367.davem@davemloft.net> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 18 Apr 2019 17:06:47 -0700 (PDT), David Miller wrote: > From: Jakub Kicinski > Date: Wed, 17 Apr 2019 13:51:54 -0700 > > > A few unrelated improvements here, mostly trying to make random > > configs build and W=1 produce a little less warnings under net/ > > and drivers net/. > > > > First two patches fix set but not used warnings with W=1. > > > > Next patch fixes 64bit division in sch_taprio.c. > > > > Last two patches are getting rid of some (almost) unused asserts > > in skbuff.h. > > Series applied, thanks Jakub. Thanks! > That l2tp one was weird, apparently that value was never ever used. Yess, the only explanation I could come up with was that Guillaume wanted to make sure user space passed a valid pointer, even if it's unused today. But that's pure speculation :S