From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 282A7C10F0E for ; Thu, 18 Apr 2019 18:30:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EF31B20643 for ; Thu, 18 Apr 2019 18:30:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="I91MKNLL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390744AbfDRSa4 (ORCPT ); Thu, 18 Apr 2019 14:30:56 -0400 Received: from mail-lf1-f68.google.com ([209.85.167.68]:43259 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390360AbfDRSat (ORCPT ); Thu, 18 Apr 2019 14:30:49 -0400 Received: by mail-lf1-f68.google.com with SMTP id i68so2348650lfi.10 for ; Thu, 18 Apr 2019 11:30:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to:user-agent; bh=BDrH2xghiWsDzu64JGgq5KXMa51VeOg5C+1Bge4S8qU=; b=I91MKNLLyTOdb9kCQ6nrk/7QWGjWrF/5oH3P8fLqYdS4dRUjU17U5ZhPv6yrlinCeE up4eQrrfAgh/gXlQaKcgLFhMjbnAJ8SNJ+tfCQ4pQwwF3vd1MmNKVizotb/GUtVGuZ89 yUFErUEIBKFwWRqhG+9U0rK+GYtzkyBJY0FHrayTeHmdXgX+PcMHZOD/xKNKzjpB/kwQ XZSNIuuAL7XM5w7LVjfGHevB3YrZoHkzYCK0WYX0TSqsoGHSTi0G1NHMnpps9lUvGto9 6ZlGzRjsu80nPeCrdqVFxiKdGlsM2N/XAAtSrev4tvifctc47cC3z8vwT615isud8PNj hGew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to:user-agent; bh=BDrH2xghiWsDzu64JGgq5KXMa51VeOg5C+1Bge4S8qU=; b=P4pbg8ptPnz6ndAvuSRmRcn/utaJswq61BB4hvDBtsfgX+fIwQHI9KE7MzSODhvMUJ uKMpLI1sDELW3KYE7r6kRAGB3J+TFlmIgnY4dCEsubu3gVIeDpzzUWt12rFN6EP7029i UHJo+dgdhEpWd8uKu8HvwJKI8g0WTa94qYzv7TFWC1/gj9TXq4MGvuBT7A/CcuynjkUS qt2gURxTIVXhSkwD44BIq+MkAWdr6KIjJqBe20nGN13LabAAjqW851D/FTETi1Dk08pr bO9aCOPj8ICXh4Hk2qtomSr2pIf/LAm7rOGS9UH9Of9QOVBq1Yfr/28mf2F3X6aZDK4w 2VDA== X-Gm-Message-State: APjAAAVOtb7SRDrOYPNd8N0pavRXKZJWzXRAznHs7Rx9Rs8POcl4sjJN 1Cvq/eTvmz1QS5ScanEi805I1w== X-Google-Smtp-Source: APXvYqwIcovas9Ysm1mVpyjhfx8EgOQTC1rEopmvlMcL+8QtpMl1zkxq2zScpsO8sYHGpdUeejC5rA== X-Received: by 2002:a19:3845:: with SMTP id d5mr18719428lfj.77.1555612247557; Thu, 18 Apr 2019 11:30:47 -0700 (PDT) Received: from khorivan (59-201-94-178.pool.ukrtel.net. [178.94.201.59]) by smtp.gmail.com with ESMTPSA id n23sm603574lfh.86.2019.04.18.11.30.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 18 Apr 2019 11:30:46 -0700 (PDT) Date: Thu, 18 Apr 2019 21:30:44 +0300 From: Ivan Khoronzhuk To: Jakub Kicinski Cc: grygorii.strashko@ti.com, linux-omap@vger.kernel.org, LKML , Linux Netdev List , ilias.apalodimas@linaro.org, hawk@kernel.org, xdp-newbies@vger.kernel.org, Alexei Starovoitov , aniel@iogearbox.net, John Fastabend Subject: Re: [RFC PATCH 3/3] net: ethernet: ti: cpsw: add XDP support Message-ID: <20190418183043.GD27879@khorivan> Mail-Followup-To: Jakub Kicinski , grygorii.strashko@ti.com, linux-omap@vger.kernel.org, LKML , Linux Netdev List , ilias.apalodimas@linaro.org, hawk@kernel.org, xdp-newbies@vger.kernel.org, Alexei Starovoitov , aniel@iogearbox.net, John Fastabend References: <20190417174942.11811-1-ivan.khoronzhuk@linaro.org> <20190417174942.11811-4-ivan.khoronzhuk@linaro.org> <20190418094008.GB27879@khorivan> <20190418104111.559a0e74@cakuba.netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20190418104111.559a0e74@cakuba.netronome.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Apr 18, 2019 at 10:41:11AM -0700, Jakub Kicinski wrote: >On Thu, 18 Apr 2019 12:40:10 +0300, Ivan Khoronzhuk wrote: >> >work? The stack's TX ring has a lock, and can be used from any CPU, >> >while XDP TX rings are per-PCU, no? >> Yes and no. >> am572 has more queues then CPU num, How I can choose tx queue not based on CPU >> num? It's always shared and has to have lock, and cpdma is done in this way. > >Oh, I see, you already have another lock. > >> Here another thing bothering me, I send it to queue 0 always, instead of >> taking cpu num. Not sure about this, but I expect to have some tx queue >> not bind to cpu and didn't find a way it can be changed dynamically in >> redirect. > >Not sure I understand :) I mean, is there a capability to choose tx queue while XDP_REDIRECT or XDP_TX. >From what I've seen it's taken by: qidx = smp_processor_id(); What if I need to send classified traffic to hw queue 4 for instance... -- Regards, Ivan Khoronzhuk