From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0DF4C10F0E for ; Thu, 18 Apr 2019 21:47:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9F8EB20652 for ; Thu, 18 Apr 2019 21:47:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="GNOAcum/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726131AbfDRVr3 (ORCPT ); Thu, 18 Apr 2019 17:47:29 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:38044 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725853AbfDRVr3 (ORCPT ); Thu, 18 Apr 2019 17:47:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=h3cw4unT5WeWBbTv3sFqPfnMjM3w8f+Y4JcFAF5GKGE=; b=GNOAcum/iqHL1mAKcP6E5SZTJQ oLLYxj0MqzAHFusf4fICXWFBC3Uo2FOwx766sl5LcOd6NtBpDfeak5+qll8+/uxgDst4Ll0/zBtoM uOJFWbZgJiy+4qGtosURTGk1n+jcPPALgiJdLYR1BThgx87DozdxSKB44T6nI7XzWQXw=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hHEsQ-0004Ij-3k; Thu, 18 Apr 2019 23:47:26 +0200 Date: Thu, 18 Apr 2019 23:47:26 +0200 From: Andrew Lunn To: Florian Fainelli Cc: David Miller , netdev , Vivien Didelot Subject: Re: [PATCH net-next 06/15] dsa: Remove const from tag driver ops structure Message-ID: <20190418214726.GE542@lunn.ch> References: <20190418023120.17067-1-andrew@lunn.ch> <20190418023120.17067-7-andrew@lunn.ch> <9439fff5-9ddd-9e49-1c1e-6b66b5aeb2c2@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9439fff5-9ddd-9e49-1c1e-6b66b5aeb2c2@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Apr 18, 2019 at 10:58:46AM -0700, Florian Fainelli wrote: > > > On 4/17/2019 7:31 PM, Andrew Lunn wrote: > > A later patch will create a linked list of tag driver ops structures, > > using a list_head in the structure. So the structure cannot be const. > > Can't we encapsulate the existing dsa_device_ops, while leaving them > const into another structure which is not const? Similar to how we did > with the dsa_switch_driver structure? Hi Florian I was trying to keep it KISS, no dynamic memory allocation. But i can make it more complex. For a tag driver with a single set of ops, i can probably hide it all in the boiler plate, and make it all static memory. For tag_brcm.c and tag_ksz.c, which have two ops structures, i'm not sure i can hide it all. I will think about it. Andrew