From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B52DEC282E0 for ; Fri, 19 Apr 2019 21:04:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7F3272171F for ; Fri, 19 Apr 2019 21:04:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="s5aOVPNr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727472AbfDSVE0 (ORCPT ); Fri, 19 Apr 2019 17:04:26 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:36339 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726000AbfDSVEZ (ORCPT ); Fri, 19 Apr 2019 17:04:25 -0400 Received: by mail-wr1-f68.google.com with SMTP id a15so3714511wrw.3 for ; Fri, 19 Apr 2019 14:04:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=mrtD/sqH+21iHkLG1/nJpRFXNu66oQST/yLRS8mlRNQ=; b=s5aOVPNrGfThgRp61sRIKbzohW+orNKxT5gBDlNCcSEhsijtplsrDDrC1GQbkWbwMn nS7LatI9XnePoxTTT9W9RGz6Wy+3kAdwegZYT3w3yBgxMyi9XzAVNhlQL3rKPHcv8C9o 5xGT1qFjcqJv9mRoY1cARALYyqb85vTLWwC/KQoijuiDl3+lb88LHXVSTcwBP23MMG0y wUluX45fJx78S+ad0O351T3Y2TqW+EabUt2h56JyQKCANNAWilynTFfFZkur0F+5QhkF VfS3Ufbf0y3aMeupwuBqQSgXg5WSLY8EHAvnqt2Srag98e4QrtlbsCCVgnglC1PI4goW Jv4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=mrtD/sqH+21iHkLG1/nJpRFXNu66oQST/yLRS8mlRNQ=; b=GSH5DWfCYEScnMQhNkttPfU7vflHQQSOfyTjBWzL0y1OFLfC+MXErOd95GGZZBH8b3 PlrD1d0eKE8SpAKkAmpI/LKNZGZbdATslHVofbUka9uqMqzowl5Op76KXzulSCZC6RjV H7ffYXX3bV5puQ1anFmQP+K281ELv7qyKz16IEEsaMTWGhQ+IY8E1yJR0HsTJFUO8mNM kj2/qWSSWXV/YhKj5U9TX3o+ZrBw+LuYGzFvL6I6i1n3iYwAw52Tsl4iIP+5mL+Di3ta 1WYd04FRufoLWFzCtic8b2BRO5OSwsxhYGPZ6lsRXkdqioMWBUuX38Ubt9idAVqO+4Nt xg4w== X-Gm-Message-State: APjAAAUGefVDOb/FDud/RU5xzTriHCf3UugmEYJp+FHUSHEf10wDgd7V SEJSE5UHBX5I/hd2SYTY6n9LZHZQGFk= X-Google-Smtp-Source: APXvYqzgvrqyWrSPKb2x3jWroLFQp7PyUMbMdobXPuKAEj9I6zoEiRAvqIEjdG+8AA7/zBXWwBne1w== X-Received: by 2002:a5d:5489:: with SMTP id h9mr1532741wrv.240.1555651666592; Thu, 18 Apr 2019 22:27:46 -0700 (PDT) Received: from localhost (ip-213-220-234-223.net.upcbroadband.cz. [213.220.234.223]) by smtp.gmail.com with ESMTPSA id o1sm3200450wmh.47.2019.04.18.22.27.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 18 Apr 2019 22:27:46 -0700 (PDT) Date: Fri, 19 Apr 2019 07:27:45 +0200 From: Jiri Pirko To: Jakub Kicinski Cc: netdev@vger.kernel.org, davem@davemloft.net, mlxsw@mellanox.com, dsahern@gmail.com Subject: Re: [patch net-next 03/15] netdevsim: rename devlink.c to dev.c to contain per-dev(asic) items Message-ID: <20190419052745.GB2247@nanopsycho> References: <20190418140614.3973-1-jiri@resnulli.us> <20190418140614.3973-4-jiri@resnulli.us> <20190418101722.19af3467@cakuba.netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190418101722.19af3467@cakuba.netronome.com> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Thu, Apr 18, 2019 at 07:17:22PM CEST, jakub.kicinski@netronome.com wrote: >On Thu, 18 Apr 2019 16:06:02 +0200, Jiri Pirko wrote: >> From: Jiri Pirko >> >> The existing devlink.c code is going to be extended to represent asic >> device on a bus. As this is about more than just devlink, >> rename the file. Do appropriate prefix renaming alongside with that. > >Again, devlink != bus device. I don't like this change at all. > >Keep them separate, please, unless you _need_ such a change for testing. I have them separate. There is just 1:1 mapping between bus_device (dev.c) file, and devlink instance. There is nothing preventing to have the mapping in a different way. This is basically just a file name change to better fit what is done in the file.