From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.7 required=3.0 tests=DATE_IN_PAST_12_24, DKIMWL_WL_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2836C282DA for ; Fri, 19 Apr 2019 20:01:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 678832171F for ; Fri, 19 Apr 2019 20:01:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="WCbOjOM0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727523AbfDSUBO (ORCPT ); Fri, 19 Apr 2019 16:01:14 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:42738 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726793AbfDSUBO (ORCPT ); Fri, 19 Apr 2019 16:01:14 -0400 Received: by mail-wr1-f67.google.com with SMTP id g3so8055409wrx.9 for ; Fri, 19 Apr 2019 13:01:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ZM8J/kMNJ75J+zrv3x1V7tujPFR6pqop4MgcSZaf1nM=; b=WCbOjOM0rfc7bmLsTELhhgKpZ8j9E/2EUt5KqbihqQTQd2cDEE1RZDrOiUdU59eXGk PNToba0StHIdBPA3IZRdegnOF3Qn0AZtaVowrG5RQVKmayiz35Q8c9xKJKZVYJUxitEr f5brH6HBHZRNLS96y6Dc8s6YkHroY3JXjoLnubtGdB91U1N/ptT7disoa+jukU/qUpsW FwoTVCvoLFoDrov9HoiyHmSzTxGgFVvZ803Kqsd7BjK57tjEkYB4hBzO4gzkUfz+L/B0 9tIe2NF3hIKgcUt+TzmDwokibMGGG96d/3UKlW7C6ZuqG88k4bq3Q9MhHSi0SChPWol8 2dQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ZM8J/kMNJ75J+zrv3x1V7tujPFR6pqop4MgcSZaf1nM=; b=eybhB9qHL0m2Noh18EVt/iZmMGyJOqiap9Zx8qnO4Qb+mJGPzGTW+hMmB2Bzv9fUgP e1V4v9b/odGeu7Z/tVwRAMPMnV6BDc1qzqkzL1Y+YOhm4z2lGPHK4+9vpyXgWjuYNieS im6WSmy44ueeyCciKkNfFclacojePSuehaLKm/k6YdxvJsq1HXSICK+cHeXDBVDnS4xa GIa30XpX34VeEMXpmGMPckqWJkuKTw9XTRc+65iEXCDqUWkC+zFPFLBrVqk2eYO1M2zv LO6JDwZ2Kbld2VKqOVu9BSL0fi7PQV2RZfNlGLQxO0x7awdtrutQrGBfLwx1Vv2wlLRt T09Q== X-Gm-Message-State: APjAAAUrZBUJBZDQtmWzU0iIsGLbYtf4xVZuF/xrD9FtVhmI/rAOhhc2 ZaNGLjxy0etfpdIcyv4ciGSP+79bypc= X-Google-Smtp-Source: APXvYqxx4Cfd6ejM5b2t+4loJlb/VTQF10DOUCVmf0UC7JI0u4EeSV9laM9wjTPly1utrf/ffaHJXw== X-Received: by 2002:adf:eb89:: with SMTP id t9mr1480480wrn.109.1555651714113; Thu, 18 Apr 2019 22:28:34 -0700 (PDT) Received: from localhost (ip-213-220-234-223.net.upcbroadband.cz. [213.220.234.223]) by smtp.gmail.com with ESMTPSA id z11sm4039026wmf.12.2019.04.18.22.28.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 18 Apr 2019 22:28:33 -0700 (PDT) Date: Fri, 19 Apr 2019 07:28:33 +0200 From: Jiri Pirko To: Jakub Kicinski Cc: netdev@vger.kernel.org, davem@davemloft.net, mlxsw@mellanox.com, dsahern@gmail.com Subject: Re: [patch net-next 14/15] netdevsim: move netdev creation/destruction to dev probe Message-ID: <20190419052833.GC2247@nanopsycho> References: <20190418140614.3973-1-jiri@resnulli.us> <20190418140614.3973-15-jiri@resnulli.us> <20190418102550.6eea3255@cakuba.netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190418102550.6eea3255@cakuba.netronome.com> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Thu, Apr 18, 2019 at 07:25:50PM CEST, jakub.kicinski@netronome.com wrote: >On Thu, 18 Apr 2019 16:06:13 +0200, Jiri Pirko wrote: >> @@ -1279,24 +1312,13 @@ try: >> start_test("Test multi-dev ASIC cross-dev destruction...") >> bpftool_prog_list_wait(expected=2) >> >> - simA.remove() >> + simdevA.remove() >> bpftool_prog_list_wait(expected=1) >> >> ifnameB = bpftool("prog show %s" % (progB))[1]["dev"]["ifname"] >> fail(ifnameB != simB1['ifname'], "program not bound to originial device") >> - simB1.remove() >> - bpftool_prog_list_wait(expected=1) >> - >> - start_test("Test multi-dev ASIC cross-dev destruction - move...") >> - ifnameB = bpftool("prog show %s" % (progB))[1]["dev"]["ifname"] >> - fail(ifnameB not in (simB2['ifname'], simB3['ifname']), >> - "program not bound to remaining devices") >> - >> - simB2.remove() >> - ifnameB = bpftool("prog show %s" % (progB))[1]["dev"]["ifname"] >> - fail(ifnameB != simB3['ifname'], "program not bound to remaining device") >> >> - simB3.remove() >> + simdevB.remove() >> bpftool_prog_list_wait(expected=0) >> >> start_test("Test multi-dev ASIC cross-dev destruction - orphaned...") > >You're removing existing tests in the name of reshuffling the code? Okay, as you wish. I will add way to add/del ports on fly. > >Hard no. > >Once devlink can do what we need here, we can reorg netdevsim. >netdevsim is for testing real interfaces.