From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CF8BC282E0 for ; Fri, 19 Apr 2019 21:11:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E97DA2171F for ; Fri, 19 Apr 2019 21:11:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="2JQLVE+G" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727392AbfDSVLj (ORCPT ); Fri, 19 Apr 2019 17:11:39 -0400 Received: from mail-qt1-f169.google.com ([209.85.160.169]:38915 "EHLO mail-qt1-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726358AbfDSVLi (ORCPT ); Fri, 19 Apr 2019 17:11:38 -0400 Received: by mail-qt1-f169.google.com with SMTP id f13so6274605qto.6 for ; Fri, 19 Apr 2019 14:11:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=ILtl0w2H9w8NmqDTNFdBLJ6OkNU5I/gyle3I9X2tMHs=; b=2JQLVE+GsPJvlDg1yr/Htlyh/CB45XX6sMSPcy/Ps7WxVwKMvFfCWNx/+pViCYoc+Y aENzmBzfYEVK/qHF1X0nT4jC4Fk0pQG/DWFUaNx/SpK+xMlvDsGFlrykfwSJTTWCa/pN kuEl5XC9QtblFQu7O5xze3RykdrdbyGraVQX4dUFI3tuyTaLumAoFMxuG60OdvdaEHUo pGa195l5ABnbPDe6Ywn95El98tcvddrnQNtubgVYH00X2I1c6qiETR2OPlj2vcl/hmuE d8bCV1wguvQXG3hoiHSxZAcq1Du2aATtgR6EHSBR8f9L7YkKvZGzCCw9vc0HIdpAHgKj eZVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=ILtl0w2H9w8NmqDTNFdBLJ6OkNU5I/gyle3I9X2tMHs=; b=o6aUD7MYgDIWIv/Upf1tM6F+efZz9NY5wxBskvlWRl+iZnK8of+MPyADg4htcHj+vk jsxPNgdObBQKZurfPHLAawoSN2/MDDtPZNPp6l8tYPCaSVb83IQc7ILutSbWmhg70dq3 sBt5FlhnF0QXGur5oe5yytWYx8lgDT4bXHwGS/F2DIrDLWLyJkckn1qZKPHoe0KnQLhh MHP/O90xE5U+S5hTzH8V481KW9C8nJOco0t1jBU6Rvntqyv2JKl33c6nD1OGgBc59kga oR1vJuD/SZKzNcKMRFt1zWZBzfDnIpXmMhivQWARjBTqOurpXCsQsngRXFlh6eYri7Dt C6Gg== X-Gm-Message-State: APjAAAWFXlVFgNdqSUkAtF230LFVEpO/0Q/5U3pdBcMcxj6dkTiXcUWO w+fGSx9C1nikSI6kw469DKK7Mg== X-Google-Smtp-Source: APXvYqw34AHHDvjmd5/Wm9OQ3iTjHfFbgaG2IKrrAwdXJRyDF4s5zGLfdBzEykWCmZdABVdBk2Cd7g== X-Received: by 2002:a0c:9e25:: with SMTP id p37mr5135928qve.201.1555708297405; Fri, 19 Apr 2019 14:11:37 -0700 (PDT) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id y6sm2841438qka.69.2019.04.19.14.11.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 19 Apr 2019 14:11:37 -0700 (PDT) Date: Fri, 19 Apr 2019 14:11:19 -0700 From: Jakub Kicinski To: Jiri Pirko Cc: netdev@vger.kernel.org, davem@davemloft.net, mlxsw@mellanox.com, dsahern@gmail.com Subject: Re: [patch net-next 14/15] netdevsim: move netdev creation/destruction to dev probe Message-ID: <20190419141119.79fd9020@cakuba.netronome.com> In-Reply-To: <20190419052833.GC2247@nanopsycho> References: <20190418140614.3973-1-jiri@resnulli.us> <20190418140614.3973-15-jiri@resnulli.us> <20190418102550.6eea3255@cakuba.netronome.com> <20190419052833.GC2247@nanopsycho> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 19 Apr 2019 07:28:33 +0200, Jiri Pirko wrote: > Thu, Apr 18, 2019 at 07:25:50PM CEST, jakub.kicinski@netronome.com wrote: > >On Thu, 18 Apr 2019 16:06:13 +0200, Jiri Pirko wrote: > >> - simB3.remove() > >> + simdevB.remove() > >> bpftool_prog_list_wait(expected=0) > >> > >> start_test("Test multi-dev ASIC cross-dev destruction - orphaned...") > > > >You're removing existing tests in the name of reshuffling the code? > > Okay, as you wish. I will add way to add/del ports on fly. Yes I wish we add tests instead of removing them. Please show us the tests you're going to add once you're through with all this core reshuffling. Maybe it'd make it easier to swallow.